From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] package.el: check tarball signature Date: Thu, 03 Oct 2013 10:19:34 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <877gdutp1l.fsf@flea.lifelogs.com> References: <874n92x9em.fsf@flea.lifelogs.com> <87fvsk9m8b.fsf-ueno@gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1380809992 13033 80.91.229.3 (3 Oct 2013 14:19:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Oct 2013 14:19:52 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 03 16:19:55 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VRjkx-0006pz-0Q for ged-emacs-devel@m.gmane.org; Thu, 03 Oct 2013 16:19:55 +0200 Original-Received: from localhost ([::1]:43524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRjkw-00031P-JO for ged-emacs-devel@m.gmane.org; Thu, 03 Oct 2013 10:19:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRjko-00030I-D2 for emacs-devel@gnu.org; Thu, 03 Oct 2013 10:19:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRjkj-0002dM-92 for emacs-devel@gnu.org; Thu, 03 Oct 2013 10:19:46 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:53397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRjkj-0002ca-2A for emacs-devel@gnu.org; Thu, 03 Oct 2013 10:19:41 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1VRjkg-0006dG-IM for emacs-devel@gnu.org; Thu, 03 Oct 2013 16:19:38 +0200 Original-Received: from c-98-229-61-72.hsd1.ma.comcast.net ([98.229.61.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 03 Oct 2013 16:19:38 +0200 Original-Received: from tzz by c-98-229-61-72.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 03 Oct 2013 16:19:38 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 28 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-61-72.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:kb6tMbykdZYoooNsfwyvRGf5LRQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163834 Archived-At: On Thu, 03 Oct 2013 16:18:46 +0900 Daiki Ueno wrote: DU> Ted Zlatanov writes: >> This looks terrific, but please make signing an option per archive, not >> per package or global. The GNU ELPA will be signed; others may not. DU> Ported package-unsigned-archives from your patch. Also, added a check DU> of archive-contents signature. Thanks for the suggestions. Wonderful. Needs documentation, though... especially the new defcustoms. Just one code comment: +(defcustom package-check-signature 'allow-unsigned + "Whether to check package signatures when installing." + :type '(choice (const nil :tag "Never") + (const allow-unsigned :tag "Allow unsigned") + (const t :tag "Check always")) + :risky t + :group 'package + :version "24.1") IMHO this should be per archive, not global. WDYT? The tests look great, too. Ted