Default language environment not calling set-language-environment-hook?

Default language environment not calling set-language-environment-hook?

[Matthias Meulien]

I ran emacs with a minimal `~/.emacs' limited to:

(add-hook 'set-language-environment-hook (lambda ()
             (message "Language environment is " 
             current-language-environment))) 
 
(message "Language environment is " current-language-environment) 
 

The *Messages* buffer contains: "Language environment is ". But 
when asking for the description of the variable 
`current-language-environment' I get:

Its value is "French" Original value was "English" 

I was expecting the `set-language-environment-hook' to be called. 
Am I wrong?
-- 
Matthias

Re: Default language environment not calling set-language-environment-hook?

[Davis Herring]

> (add-hook 'set-language-environment-hook (lambda ()
>             (message "Language environment is "            
> current-language-environment)))
> (message "Language environment is " current-language-environment)
> 
> The *Messages* buffer contains: "Language environment is ".

Not your question, but you surely want to put %s (or %S) into your
`message' format string so that the value of
`current-language-environment' is actually printed.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: Default language environment not calling set-language-environment-hook?

[Matthias Meulien]

Davis Herring <herring@lanl.gov> writes:

> Not your question, but you surely want to put %s (or %S) into 
> your `message' format string so that the value of 
> `current-language-environment' is actually printed.

You are right. Thanks!

Nonetheless, `set-language-environment-hook' is not called at startup
with emacs trunk.
-- 
Matthias

Re: Default language environment not calling set-language-environment-hook?

[Eli Zaretskii]

> From: Matthias Meulien <orontee@gmail.com>
> Date: Tue, 26 Nov 2013 00:29:36 +0100
> 
> Nonetheless, `set-language-environment-hook' is not called at startup
> with emacs trunk.

I think this is because set-language-environment is called by
startup.el before it processes your .emacs, so the hook is not yet
set.

Re: Default language environment not calling set-language-environment-hook?

[Matthias Meulien]

> I think this is because set-language-environment is called by
> startup.el before it processes your .emacs, so the hook is not yet
> set.

That's it!

Should not the docstring of `set-language-environment-hook' warn
developers about this? Something like:

During the start-up process, `set-language-environment' is called
before the user init file is read. Thus adding functions to that
hook in the user init file will have no effect while setting the
default language environment.
-- 
Matthias

Re: Default language environment not calling set-language-environment-hook?

[Eli Zaretskii]

> Date: Tue, 26 Nov 2013 10:16:43 +0100
> From: Matthias Meulien <orontee@gmail.com>
> Cc: emacs-devel@gnu.org
> 
> Should not the docstring of `set-language-environment-hook' warn
> developers about this? Something like:
> 
> During the start-up process, `set-language-environment' is called
> before the user init file is read. Thus adding functions to that
> hook in the user init file will have no effect while setting the
> default language environment.

Sounds far-fetched to me.  People who want to hook into the startup
procedure should rather use a couple of hooks provided specifically
for that purpose, like before-init-hook, after-init-hook, etc.