From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16035@debbugs.gnu.org, Anders Lindgren <andlind@gmail.com>
Subject: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode)
Date: Fri, 06 Dec 2013 02:57:22 +0200 [thread overview]
Message-ID: <877gbi94p9.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvob4wf23u.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Wed, 04 Dec 2013 21:45:37 -0500")
>> +(defvar isearch-saved-overriding-local-map nil)
>
> Oops, now that I see it, I think this one deserves a double-dash.
>
>> (setq overriding-terminal-local-map isearch-mode-map)
>> (run-hooks 'isearch-mode-hook)
>> + (setq isearch-saved-overriding-local-map overriding-terminal-local-map)
>
> Please include a comment referring either to folding-isearch or to this bug.
The patch is installed now including these corrections.
Now I discovered another case that fails to move point
after exiting Isearch. Running `multi-isearch-buffers'
and typing e.g. `C-a' exits Isearch but doesn't move point
to the beginning of the line.
The problem is that `multi-isearch-buffers' let-binds
`multi-isearch-buffer-list' to the list of buffers,
and invokes `isearch-forward' without NO-RECURSIVE-EDIT,
so dynamic binding of `multi-isearch-buffer-list' is
available for Isearch to get the next buffer to search.
But after exiting in `isearch-pre-command-hook',
`isearch-done' calls `exit-recursive-edit'
that prevents this-command from executing
(in this case `move-beginning-of-line' is not executed).
So `isearch-forward' in `multi-isearch-buffers'
should be invoked with non-nil NO-RECURSIVE-EDIT argument, and
then `multi-isearch-buffer-list' needs to be a global variable.
Exactly the same problem exists in `dired-isearch-filenames'
that let-binds `dired-isearch-filenames' and calls `isearch-forward'
without NO-RECURSIVE-EDIT. And in `comint-history-isearch-backward'
that let-binds `comint-history-isearch'. These variables
should be global. Maybe this is not the right solution,
but I have no better ideas.
next prev parent reply other threads:[~2013-12-06 0:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 9:38 bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Anders Lindgren
2013-12-04 0:14 ` Juri Linkov
2013-12-04 0:18 ` Juri Linkov
2013-12-04 0:37 ` Juri Linkov
2013-12-04 4:31 ` Stefan Monnier
2013-12-04 11:48 ` Anders Lindgren
2013-12-04 17:57 ` Stefan Monnier
2013-12-04 21:49 ` Anders Lindgren
2013-12-05 1:20 ` Juri Linkov
2013-12-05 2:45 ` Stefan Monnier
2013-12-06 0:57 ` Juri Linkov [this message]
2013-12-11 0:12 ` Juri Linkov
2013-12-16 8:13 ` Anders Lindgren
2013-12-16 20:32 ` Juri Linkov
2013-12-17 6:17 ` Anders Lindgren
2013-12-17 19:38 ` Juri Linkov
2013-12-18 8:02 ` Anders Lindgren
2013-12-18 23:22 ` Juri Linkov
2013-12-19 13:35 ` Stefan Monnier
2013-12-19 20:39 ` Juri Linkov
2013-12-05 15:33 ` Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gbi94p9.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=16035@debbugs.gnu.org \
--cc=andlind@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.