From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14162: 24.3.50; regression: warning of obsolete function for `mouse-choose-completion' Date: Sat, 08 Feb 2014 04:39:21 -0800 Message-ID: <877g95srra.fsf@building.gnus.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1391863270 8400 80.91.229.3 (8 Feb 2014 12:41:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Feb 2014 12:41:10 +0000 (UTC) Cc: 14162@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 08 13:41:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WC7Dh-00028B-0r for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 13:41:17 +0100 Original-Received: from localhost ([::1]:46348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC7Dg-0005e5-IA for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 07:41:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC7DX-0005do-NT for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:41:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WC7DS-0004xw-Nj for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:41:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC7DS-0004xr-Kb for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WC7DR-0007nZ-M1 for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Feb 2014 12:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14162-submit@debbugs.gnu.org id=B14162.139186324929957 (code B ref 14162); Sat, 08 Feb 2014 12:41:01 +0000 Original-Received: (at 14162) by debbugs.gnu.org; 8 Feb 2014 12:40:49 +0000 Original-Received: from localhost ([127.0.0.1]:56616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7DD-0007n6-SC for submit@debbugs.gnu.org; Sat, 08 Feb 2014 07:40:48 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40620) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7DB-0007mx-D1 for 14162@debbugs.gnu.org; Sat, 08 Feb 2014 07:40:46 -0500 Original-Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WC7Cw-0002Wb-LR; Sat, 08 Feb 2014 13:40:31 +0100 In-Reply-To: (Drew Adams's message of "Mon, 8 Apr 2013 16:03:03 -0700") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1WC7Cw-0002Wb-LR MailScanner-NULL-Check: 1392468031.4985@N6jysX3aTawVm6kPwWnUcw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:84948 Archived-At: "Drew Adams" writes: > This does not happen in Emacs 24.3. The problem was introduced after > that, apparently. > > emacs -Q > > M-x customize-face mode-line TAB TAB > > In *Completions*, click mouse-2 on a candidate. > > You get the message: > > `mouse-choose-completion' is an obsolete command (as of 23.2); use > `choose-completion' instead. > > Emacs -Q should not, itself, be giving us stuff it needs to warn us > about. Yeah, that should be unnecessary. I'm not familiar with that code, though. Is it safe to just replace all relevant `mouse-choose-completion' entries in the list below? -*- mode: grep; default-directory: "~/src/emacs/trunk/lisp/" -*- Grep started at Sat Feb 8 04:37:49 grep -nH -e mouse-choose-completion `find . -name '*.el'` ./simple.el:6824: (define-key map [mouse-2] 'mouse-choose-completion) ./simple.el:7074:Use \\\\[mouse-choose-completion] to select one\ ./simple.el:7133: "Click \\[mouse-choose-completion] on a completion to select it.\n"))) ./comint.el:3324: (eq (key-binding key) 'mouse-choose-completion))) ./comint.el:3325: ;; If the user does mouse-choose-completion with the mouse, ./mouse.el:1697: 'mouse-choose-completion 'choose-completion "23.2") ./filecache.el:646:(define-obsolete-function-alias 'file-cache-mouse-choose-completion ./term.el:4140: (eq (key-binding key) 'mouse-choose-completion))) ./term.el:4141: ;; If the user does mouse-choose-completion with the mouse, ./progmodes/idlwave.el:7139: "Replace `choose-completion' and `mouse-choose-completion' in OLD-MAP." ./progmodes/idlwave.el:7162: "Replace `choose-completion' and `mouse-choose-completion' in OLD-MAP." ./progmodes/idlwave.el:7167: 'mouse-choose-completion 'idlwave-mouse-choose-completion new-map) ./progmodes/idlwave.el:7176:(defun idlwave-mouse-choose-completion (&rest args) ./progmodes/idlwave.el:7179: (apply 'idlwave-choose 'mouse-choose-completion args)) ./international/quail.el:300: (define-key map [mouse-2] 'quail-mouse-choose-completion) ./international/quail.el:2262:(defun quail-mouse-choose-completion (event) ./international/quail.el:2265: ;; `mouse-choose-completion' except that we: Grep finished (matches found) at Sat Feb 8 04:37:49 -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/