From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alex =?utf-8?Q?Benn=C3=A9e?= Newsgroups: gmane.emacs.devel Subject: Re: bug#16599: src/temacs --daemon fails Date: Mon, 17 Feb 2014 07:40:35 +0000 Message-ID: <877g8unq4s.fsf@bennee.com> References: <87bnyt5zmi.fsf@linaro.org> <83k3dh7837.fsf@gnu.org> <878utaoi66.fsf__22889.092230662$1392587661$gmane$org@bennee.com> <871tz2iuuu.fsf@igel.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1392622858 10092 80.91.229.3 (17 Feb 2014 07:40:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Feb 2014 07:40:58 +0000 (UTC) Cc: Eli Zaretskii , 16599@debbugs.gnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 17 08:41:01 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WFIp0-0003pf-G5 for ged-emacs-devel@m.gmane.org; Mon, 17 Feb 2014 08:40:58 +0100 Original-Received: from localhost ([::1]:38330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFIoz-0007md-T8 for ged-emacs-devel@m.gmane.org; Mon, 17 Feb 2014 02:40:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFIos-0007mF-Qh for emacs-devel@gnu.org; Mon, 17 Feb 2014 02:40:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFIoo-0003S5-Fy for emacs-devel@gnu.org; Mon, 17 Feb 2014 02:40:50 -0500 Original-Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:59155 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFIoo-0003Rk-9N; Mon, 17 Feb 2014 02:40:46 -0500 Original-Received: from localhost ([127.0.0.1]) by socrates.bennee.com with esmtp (Exim 4.80) (envelope-from ) id 1WFIs0-0006YG-2C; Mon, 17 Feb 2014 08:44:04 +0100 User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50 In-reply-to: <871tz2iuuu.fsf@igel.home> X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: kernel-hacker@bennee.com X-SA-Exim-Scanned: No (on socrates.bennee.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 88.198.71.155 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169686 Archived-At: Andreas Schwab writes: > Alex Bennée writes: > >> diff --git a/src/emacs.c b/src/emacs.c >> index 18f6a08..66f47ef 100644 >> --- a/src/emacs.c >> +++ b/src/emacs.c >> @@ -201,7 +201,7 @@ static char *daemon_name; >> >> /* Pipe used to send exit notification to the daemon parent at >> startup. */ >> -int daemon_pipe[2]; >> +int daemon_pipe[2] = {0, 0}; > > This is redundant. Indeed. I wasn't sure if the code I replaced relied on some special difference between .data and .bss sections. I have to admit I'm unfamiliar with how the Emacs dumping mechanism works. Why did the syms_of_emacs() function feel the need to initialise daemon_pipe? > > Andreas. -- Alex Bennée