From: Yasushi SHOJI <yashi@atmark-techno.com>
To: bzg@gnu.org
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-plot: Handle explicit date/time index
Date: Tue, 25 Mar 2014 06:37:45 +0900 [thread overview]
Message-ID: <877g7jcm6u.wl@dns1.atmark-techno.com> (raw)
In-Reply-To: <87bnwwhi52.fsf@bzg.ath.cx>
Hi Bastien,
At Sun, 23 Mar 2014 19:41:45 +0100,
Bastien wrote:
>
> Yasushi SHOJI <yashi@atmark-techno.com> writes:
>
> > * lisp/org-plot.el (org-plot-quote-tsv-field): Dump data as is when
> > `timeind' is set.
>
> This change produces a compiler warning:
>
> In org-plot-quote-tsv-field:
> org-plot.el:113:22:Warning: reference to free variable `params'
Thank you for catching this.
I guess I have to re-think the whole thing. The current code by-passes
the quoting function for _all_ fields, not just for the index when
`timeind' is present. This surely breaks for others.
I don't have much time today. So, please give me a day or two.
Meanwhile, Bastien, would you mind to revert the commit for me?
Thanks,
--
yashi
next prev parent reply other threads:[~2014-03-24 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 17:26 [PATCH] org-plot: Handle explicit date/time index Yasushi SHOJI
2014-03-13 11:58 ` Bastien
2014-03-13 12:45 ` Yasushi SHOJI
2014-03-23 18:41 ` Bastien
2014-03-24 21:37 ` Yasushi SHOJI [this message]
2014-03-25 8:26 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g7jcm6u.wl@dns1.atmark-techno.com \
--to=yashi@atmark-techno.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.