all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#17653: 24.3; Tramp doesn't detect ssh ControlMaster
@ 2014-05-31 14:04 Juliusz Chroboczek
  2014-06-01  8:20 ` Michael Albinus
  0 siblings, 1 reply; 5+ messages in thread
From: Juliusz Chroboczek @ 2014-05-31 14:04 UTC (permalink / raw)
  To: 17653

(tramp-detect-ssh-controlmaster)
nil
(call-process "ssh" nil t nil "-o" "ControlMaster")
command-line line 0: missing argument.
255

The issue is that tramp-detect-ssh-controlmaster looks for the fixed
string "Missing ControlMaster argument", while my version of ssh returns
a differently worded error message.

On a related note -- there doesn't seem to be a way of working around that
without resorting to advice, there's no defvar to tweak.

-- Juliusz





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#17653: 24.3; Tramp doesn't detect ssh ControlMaster
  2014-05-31 14:04 bug#17653: 24.3; Tramp doesn't detect ssh ControlMaster Juliusz Chroboczek
@ 2014-06-01  8:20 ` Michael Albinus
  2014-06-01 11:52   ` Juliusz Chroboczek
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2014-06-01  8:20 UTC (permalink / raw)
  To: Juliusz Chroboczek; +Cc: 17653

Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr> writes:

> (tramp-detect-ssh-controlmaster)
> nil
> (call-process "ssh" nil t nil "-o" "ControlMaster")
> command-line line 0: missing argument.
> 255
>
> The issue is that tramp-detect-ssh-controlmaster looks for the fixed
> string "Missing ControlMaster argument", while my version of ssh returns
> a differently worded error message.

In the current pretest of Emacs 24.4 as well in recent Tramp versions,
the defun `tramp-detect-ssh-controlmaster' is replaced by a defconst
`tramp-ssh-controlmaster-options'. The defcustom
`tramp-use-ssh-controlmaster-options' controls whether you use it.

> On a related note -- there doesn't seem to be a way of working around that
> without resorting to advice, there's no defvar to tweak.

The native way to fix this in Tramp is tweaking `tramp-methods'. Add a
new method "myssh" with your preferred arguments.

Confirmed, `tramp-methods' is under-documented. I could guide you in
case of problems.

> -- Juliusz

Best regards, Michael.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#17653: 24.3; Tramp doesn't detect ssh ControlMaster
  2014-06-01  8:20 ` Michael Albinus
@ 2014-06-01 11:52   ` Juliusz Chroboczek
  2014-06-01 15:42     ` Michael Albinus
  0 siblings, 1 reply; 5+ messages in thread
From: Juliusz Chroboczek @ 2014-06-01 11:52 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 17653

>> The issue is that tramp-detect-ssh-controlmaster looks for the fixed
>> string "Missing ControlMaster argument", while my version of ssh returns
>> a differently worded error message.

> The native way to fix this in Tramp is tweaking `tramp-methods'. Add a
> new method "myssh" with your preferred arguments.

I know I can tweak it -- that's Emacs, I can advise any function -- but
that's not the issue.  I expect Emacs to work optimally out of the box on
an up-to-date Debian testing box, and this is not the case.

Ideally, tramp should use a less fragile method to check for ControlMaster
support; if that's not possible, it should at least use a regexp that's
permissive enough to work on recent OpenSSH.

Please fix Emacs to detect ControlMaster out of the box with recent Debian.

-- Juliusz






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#17653: 24.3; Tramp doesn't detect ssh ControlMaster
  2014-06-01 11:52   ` Juliusz Chroboczek
@ 2014-06-01 15:42     ` Michael Albinus
       [not found]       ` <878upfpeo4.wl%jch@pps.univ-paris-diderot.fr>
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2014-06-01 15:42 UTC (permalink / raw)
  To: Juliusz Chroboczek; +Cc: 17653

Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr> writes:

>> The native way to fix this in Tramp is tweaking `tramp-methods'. Add a
>> new method "myssh" with your preferred arguments.
>
> I know I can tweak it -- that's Emacs, I can advise any function -- but
> that's not the issue.  I expect Emacs to work optimally out of the box on
> an up-to-date Debian testing box, and this is not the case.

I don't speak about advising a function. `tramp-methods' is a variable
intended for configuration.

> Ideally, tramp should use a less fragile method to check for ControlMaster
> support; if that's not possible, it should at least use a regexp that's
> permissive enough to work on recent OpenSSH.
>
> Please fix Emacs to detect ControlMaster out of the box with recent Debian.

Well, in Emacs 24.4 the situation will be more complex, because Tramp
doesn't search for ControlMaster only, but also for ControlPersist. One
regexp alone won't fit.

That's why there exists the defconst `tramp-ssh-controlmaster-options'.
You could change it at your will.

However, I will check whether the situation with Debian could be
enhanced, somehow.

> -- Juliusz

Best regards, Michael.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#17653: 24.3; Tramp doesn't detect ssh ControlMaster
       [not found]       ` <878upfpeo4.wl%jch@pps.univ-paris-diderot.fr>
@ 2014-06-03  7:55         ` Michael Albinus
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Albinus @ 2014-06-03  7:55 UTC (permalink / raw)
  To: Juliusz Chroboczek; +Cc: 17653-done

Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr> writes:

Hi Juliusz,

>> However, I will check whether the situation with Debian could be
>> enhanced, somehow.
>
> Please do, and thanks.

I've fixed it in the emacs-24 branch, which will become Emacs 24.4. It
is also fixed in the Tramp repository; Tramp 2.2.10 will be released
within one or two weeks.

> -- Juliusz

Best regards, Michael.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-06-03  7:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-31 14:04 bug#17653: 24.3; Tramp doesn't detect ssh ControlMaster Juliusz Chroboczek
2014-06-01  8:20 ` Michael Albinus
2014-06-01 11:52   ` Juliusz Chroboczek
2014-06-01 15:42     ` Michael Albinus
     [not found]       ` <878upfpeo4.wl%jch@pps.univ-paris-diderot.fr>
2014-06-03  7:55         ` Michael Albinus

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.