Is `gnutls-negotiate' missing a `copy-sequence'?

Is `gnutls-negotiate' missing a `copy-sequence'?

[Mario Lang]

Hi.

Just noticed this piece of code in `gnutls-negotiate':

         (verify-error (or verify-error
                           ;; this uses the value of `gnutls-verify-error'
                           (cond
                            ;; if t, pass it on
                            ((eq gnutls-verify-error t)
                             t)
                            ;; if a list, look for hostname matches
                            ((listp gnutls-verify-error)
                             (cl-mapcan
                              (lambda (check)
                                (when (string-match (car check) hostname)
                                  (cdr check)))
                              gnutls-verify-error))
                            ;; else it's nil
                            (t nil))))

Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
destructively modify it.  Am I missing something, or should we add a
`copy-sequence' around the `cdr'?

-- 
CYa,
  ⡍⠁⠗⠊⠕

Re: Is `gnutls-negotiate' missing a `copy-sequence'?

[Stefan Monnier]

> Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
> destructively modify it.  Am I missing something, or should we add a
> `copy-sequence' around the `cdr'?

Sounds about right.  The destructive nature of cl-mapcan sucks.


        Stefan

Re: Is `gnutls-negotiate' missing a `copy-sequence'?

[Ted Zlatanov]

On Tue, 01 Jul 2014 12:17:30 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

>> Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
>> destructively modify it.  Am I missing something, or should we add a
>> `copy-sequence' around the `cdr'?

SM> Sounds about right.  The destructive nature of cl-mapcan sucks.

Thanks for catching and fixing this, guys.  I'll keep this in mind in
the future.

Ted