From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mario Lang Newsgroups: gmane.emacs.devel Subject: Is `gnutls-negotiate' missing a `copy-sequence'? Date: Tue, 01 Jul 2014 17:42:24 +0200 Message-ID: <877g3x2ihr.fsf@fx.delysid.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1404229375 12011 80.91.229.3 (1 Jul 2014 15:42:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Jul 2014 15:42:55 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 01 17:42:48 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X20Cm-0007TB-4a for ged-emacs-devel@m.gmane.org; Tue, 01 Jul 2014 17:42:48 +0200 Original-Received: from localhost ([::1]:48468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X20Cl-00005S-F6 for ged-emacs-devel@m.gmane.org; Tue, 01 Jul 2014 11:42:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X20Cb-0008WD-3y for emacs-devel@gnu.org; Tue, 01 Jul 2014 11:42:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X20CS-0005ir-CC for emacs-devel@gnu.org; Tue, 01 Jul 2014 11:42:37 -0400 Original-Received: from fep16.mx.upcmail.net ([62.179.121.36]:48715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X20CS-0005hT-0t for emacs-devel@gnu.org; Tue, 01 Jul 2014 11:42:28 -0400 Original-Received: from edge03.upcmail.net ([192.168.13.238]) by viefep16-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20140701154225.ICSZ709.viefep16-int.chello.at@edge03.upcmail.net> for ; Tue, 1 Jul 2014 17:42:25 +0200 Original-Received: from fx.delysid.org ([80.109.200.215]) by edge03.upcmail.net with edge id M3iQ1o02J4fLMH4033iQoP; Tue, 01 Jul 2014 17:42:25 +0200 X-SourceIP: 80.109.200.215 Original-Received: from mlang by fx.delysid.org with local (Exim 4.82) (envelope-from ) id 1X20CO-0003lx-QJ for emacs-devel@gnu.org; Tue, 01 Jul 2014 17:42:24 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 62.179.121.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172839 Archived-At: Hi. Just noticed this piece of code in `gnutls-negotiate': (verify-error (or verify-error ;; this uses the value of `gnutls-verify-error' (cond ;; if t, pass it on ((eq gnutls-verify-error t) t) ;; if a list, look for hostname matches ((listp gnutls-verify-error) (cl-mapcan (lambda (check) (when (string-match (car check) hostname) (cdr check))) gnutls-verify-error)) ;; else it's nil (t nil)))) Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will destructively modify it. Am I missing something, or should we add a `copy-sequence' around the `cdr'? --=20 CYa, =E2=A1=8D=E2=A0=81=E2=A0=97=E2=A0=8A=E2=A0=95