From: Mario Lang <mlang@delysid.org>
To: emacs-devel@gnu.org
Subject: Is `gnutls-negotiate' missing a `copy-sequence'?
Date: Tue, 01 Jul 2014 17:42:24 +0200 [thread overview]
Message-ID: <877g3x2ihr.fsf@fx.delysid.org> (raw)
Hi.
Just noticed this piece of code in `gnutls-negotiate':
(verify-error (or verify-error
;; this uses the value of `gnutls-verify-error'
(cond
;; if t, pass it on
((eq gnutls-verify-error t)
t)
;; if a list, look for hostname matches
((listp gnutls-verify-error)
(cl-mapcan
(lambda (check)
(when (string-match (car check) hostname)
(cdr check)))
gnutls-verify-error))
;; else it's nil
(t nil))))
Hmm, `gnutls-verify-error' is a defcustom, and `cl-mapcan' will
destructively modify it. Am I missing something, or should we add a
`copy-sequence' around the `cdr'?
--
CYa,
⡍⠁⠗⠊⠕
next reply other threads:[~2014-07-01 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 15:42 Mario Lang [this message]
2014-07-01 16:17 ` Is `gnutls-negotiate' missing a `copy-sequence'? Stefan Monnier
2014-07-30 20:43 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g3x2ihr.fsf@fx.delysid.org \
--to=mlang@delysid.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.