From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#18131: patch update Date: Mon, 28 Jul 2014 11:26:20 -0700 Message-ID: <877g2xtk4z.fsf@secretsauce.net> References: <878undtl18.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1406572051 3495 80.91.229.3 (28 Jul 2014 18:27:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Jul 2014 18:27:31 +0000 (UTC) To: 18131@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 28 20:27:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XBpdn-0002s9-Pl for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 20:27:20 +0200 Original-Received: from localhost ([::1]:41813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBpdn-0000uq-DG for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 14:27:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBpde-0000qT-6L for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 14:27:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBpdX-0004iq-3E for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 14:27:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBpdW-0004im-VW for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 14:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XBpdW-000287-Ln for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 14:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jul 2014 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18131-submit@debbugs.gnu.org id=B18131.14065719928126 (code B ref 18131); Mon, 28 Jul 2014 18:27:02 +0000 Original-Received: (at 18131) by debbugs.gnu.org; 28 Jul 2014 18:26:32 +0000 Original-Received: from localhost ([127.0.0.1]:41227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBpcy-00026q-2z for submit@debbugs.gnu.org; Mon, 28 Jul 2014 14:26:32 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34761) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBpct-00026e-7H for 18131@debbugs.gnu.org; Mon, 28 Jul 2014 14:26:27 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by gateway1.nyi.internal (Postfix) with ESMTP id A237521F58 for <18131@debbugs.gnu.org>; Mon, 28 Jul 2014 14:26:21 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 28 Jul 2014 14:26:22 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=references:from:to:subject:in-reply-to:date:message-id :mime-version:content-type; s=mesmtp; bh=W+c0znmiM94GkVKc5KMi2AD kO8I=; b=L4rfZX4cgxnHiGW9KZhWQ20sucMmDVfWH+FV2ENTM3PVcedk3sxhK5w z6ybXgW8IH6B4uHB9UvH7Kf9nEmdKYC/7ZHMzzlOc5WLfs6AG/jLL9QvT5xYFxXq 6ka7ybju+2VrnSRaupM2a8ECOxOP6uepnuQ9evAUQKkC6TpAIe7k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=references:from:to:subject:in-reply-to :date:message-id:mime-version:content-type; s=smtpout; bh=W+c0zn miM94GkVKc5KMi2ADkO8I=; b=fLCxwOJ+msReKjF9Ltr8qsN5ivRVibAxuY4LCT kcMLgeaEu9wi4THlzM1iILq0bYlTlVBaSKaZ9ooWxw24k53NqNQ61G/mMtaoZ0Qt 9qaAhNf3orqJL4o/oiiYhrxdWIpG8JLdwxVOvUbLJwG7MoqMEQ/tAs7lVAFQbEHr LtuaY= X-Sasl-enc: M+/3BvsasNSFsg+QrHd+6QfWq6YnNApOdL0uKlkviHph 1406571981 Original-Received: from shorty.local (unknown [23.243.199.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 45AF468025D for <18131@debbugs.gnu.org>; Mon, 28 Jul 2014 14:26:21 -0400 (EDT) Original-Received: from ip6-localhost ([::1] helo=shorty.local) by shorty.local with esmtp (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1XBpcq-0001Dz-3x for 18131@debbugs.gnu.org; Mon, 28 Jul 2014 11:26:20 -0700 User-agent: mu4e 0.9.9.6pre3; emacs 24.4.50.1 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91896 Archived-At: --=-=-= Content-Type: text/plain I jumped the gun with that patch a bit. Here's an updated version --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-View-search-.-now-hit-all-the-matches-regardless-of-.patch >From 5c300c00db8de26074b7b537e1cebde19a5574e7 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Mon, 28 Jul 2014 11:05:00 -0700 Subject: [PATCH] View-search-... now hit all the matches, regardless of window position Prior to this patch anything between (point) and the edge of the window was skipped. This was counterintuitive (not what less or vim do) and was not mentioned in the documentation --- lisp/view.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/view.el b/lisp/view.el index 9f914b0..698a73c 100644 --- a/lisp/view.el +++ b/lisp/view.el @@ -960,7 +960,7 @@ for highlighting the match that is found." (t (error "No previous View-mode search"))) (save-excursion (if end (goto-char (if (< times 0) (point-max) (point-min))) - (move-to-window-line (if (< times 0) 0 -1))) + (forward-line (if (< times 0) -1 1))) (if (if no (view-search-no-match-lines times regexp) (re-search-forward regexp nil t times)) (setq where (point)))) -- 2.0.0 --=-=-=--