From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stephen J. Turnbull" Newsgroups: gmane.emacs.devel Subject: Re: Your commit 7409a79 Date: Mon, 08 Dec 2014 11:28:48 +0900 Message-ID: <877fy2kh7j.fsf@uwakimon.sk.tsukuba.ac.jp> References: <83h9x917il.fsf@gnu.org> <85k324h0hg.fsf@stephe-leake.org> <83k324yv44.fsf@gnu.org> <85tx17dqzy.fsf@stephe-leake.org> <54850587.4080006@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: ger.gmane.org 1418005764 11810 80.91.229.3 (8 Dec 2014 02:29:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Dec 2014 02:29:24 +0000 (UTC) Cc: Stephen Leake , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 08 03:29:17 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xxo4Y-0002aC-Mt for ged-emacs-devel@m.gmane.org; Mon, 08 Dec 2014 03:29:14 +0100 Original-Received: from localhost ([::1]:59825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxo4Y-0008QR-6b for ged-emacs-devel@m.gmane.org; Sun, 07 Dec 2014 21:29:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxo4O-0008Q8-8z for emacs-devel@gnu.org; Sun, 07 Dec 2014 21:29:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xxo4G-0003Zr-Pa for emacs-devel@gnu.org; Sun, 07 Dec 2014 21:29:04 -0500 Original-Received: from shako.sk.tsukuba.ac.jp ([130.158.97.161]:39476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxo4G-0003YV-Fh for emacs-devel@gnu.org; Sun, 07 Dec 2014 21:28:56 -0500 Original-Received: from uwakimon.sk.tsukuba.ac.jp (uwakimon.sk.tsukuba.ac.jp [130.158.99.156]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by shako.sk.tsukuba.ac.jp (Postfix) with ESMTPS id 6A7F01C3898; Mon, 8 Dec 2014 11:28:48 +0900 (JST) Original-Received: by uwakimon.sk.tsukuba.ac.jp (Postfix, from userid 1000) id 51CB81A2CFC; Mon, 8 Dec 2014 11:28:48 +0900 (JST) In-Reply-To: <54850587.4080006@cs.ucla.edu> X-Mailer: VM undefined under 21.5 (beta34) "kale" acf1c26e3019 XEmacs Lucid (x86_64-unknown-linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 130.158.97.161 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179351 Archived-At: Paul Eggert writes: > When a commit merely renames files, wouldn't it be better for the > subject line to explain the underlying reason for the change? If the rename is out of the blue, yes. But when does that happen? Almost always renames happen in the context of other work and multiple commits (some "pure renames" and some content changes) makes sense. I would do the other work that the rename is intended to support on a branch, do the rename, and then a merge commit with a commit message like Clarify CONTRIBUTE and make it prominently visible. Step one in a revolutionary program to attract more contributors to Emacs. - Move from etc/ to top level for visibility in ls and git-browser. - Specify format of commit log summaries. - etc, etc Then the rename commit can be trivial with a simple statement of fact: Rename etc/CONTRIBUTE to ./CONTRIBUTE. Of course this style of committing and logs would be an insuperable barrier to contribution if it were made policy. ;-) Regards,