all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* read-command, read-variable, read-buffer implemented in C
@ 2014-12-13  4:25 Óscar Fuentes
  2014-12-13  5:53 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Óscar Fuentes @ 2014-12-13  4:25 UTC (permalink / raw)
  To: emacs-devel

I guess it is an historical artifact due to performance concerns, but
now it doesn't make much sense anymore, right?

Some extensions need to jump through hoops because of this. For using
Ido (almost) everywhere it would be enough to advise `completing-read',
which is what those functions end using, but as advices are not
effective for functions defined in C when they are called from other C
functions, extensions such as ido-hacks are forced to advise the
functions that call read-*, which is quite a hassle.

Or I'm wrong wrt adivising C functions and overlooking other
considerations?




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: read-command, read-variable, read-buffer implemented in C
  2014-12-13  4:25 read-command, read-variable, read-buffer implemented in C Óscar Fuentes
@ 2014-12-13  5:53 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2014-12-13  5:53 UTC (permalink / raw)
  To: Óscar Fuentes; +Cc: emacs-devel

> I guess it is an historical artifact due to performance concerns, but
> now it doesn't make much sense anymore, right?

Indeed.

> Some extensions need to jump through hoops because of this. For using
> Ido (almost) everywhere it would be enough to advise `completing-read',
> which is what those functions end using, but as advices are not
> effective for functions defined in C when they are called from other C
> functions, extensions such as ido-hacks are forced to advise the
> functions that call read-*, which is quite a hassle.

We introduced completing-read-function for that.


        Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-13  5:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-13  4:25 read-command, read-variable, read-buffer implemented in C Óscar Fuentes
2014-12-13  5:53 ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.