From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options. Date: Sun, 14 Dec 2014 12:09:07 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <877fxuxioc.fsf@lifelogs.com> References: <20141214114850.13638.56381@vcs.savannah.gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418577044 23394 80.91.229.3 (14 Dec 2014 17:10:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Dec 2014 17:10:44 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 14 18:10:37 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0Cgm-00057f-UE for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 18:10:37 +0100 Original-Received: from localhost ([::1]:36622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Cgl-0003Yd-Ur for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 12:10:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0CgP-0003YI-8r for emacs-devel@gnu.org; Sun, 14 Dec 2014 12:10:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0CgJ-0007Di-8Y for emacs-devel@gnu.org; Sun, 14 Dec 2014 12:10:13 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:56178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0CgJ-0007Bt-0f for emacs-devel@gnu.org; Sun, 14 Dec 2014 12:10:07 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Y0CgG-00043D-Nm for emacs-devel@gnu.org; Sun, 14 Dec 2014 18:10:04 +0100 Original-Received: from c-98-229-61-72.hsd1.ma.comcast.net ([98.229.61.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 14 Dec 2014 18:10:04 +0100 Original-Received: from tzz by c-98-229-61-72.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 14 Dec 2014 18:10:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 28 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-61-72.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:UfEMMxT5QyyOulGybAkfQk9d1OE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180096 Archived-At: On Sun, 14 Dec 2014 09:36:00 -0500 Stefan Monnier wrote: SM> Looks good, with the following nitpicks >> * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): Add a >> mechanism for prompting user about unsaved customizations. SM> These two lines mean "change the custom-prompt-customize-unsaved-options SM> by adding a mechanism for ...", which is not what the patch does. SM> Instead, they should just say SM> * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): New function. SM> Additionally, this text fails to mention custom-unsaved-options or the SM> fact that customize-unsaved has been modified, so I'd write: SM> * lisp/cus-edit.el (custom-unsaved-options): New function, extracted SM> from customize-unsaved. SM> (custom-unsaved): Use it. SM> (custom-prompt-customize-unsaved-options): New function. OK, I installed it earlier and have now added a commit to just fix that ChangeLog entry. FWIW, I think your version does not explain what the change provides, only that it was made (it basically restates the diff). I don't know if that's what you intended. Ted