bug#17777: 24.3.91; Word motion commands are broken

bug#17777: 24.3.91; Word motion commands are broken

[Juri Linkov]

For testing I tried to set `visual-order-cursor-movement' to t
and noticed that it breaks the word motion commands in keyboard macros.
Steps to reproduce:

0. emacs -Q
1. (setq visual-order-cursor-movement t)
2. (insert "word word word")
3. C-a C-x ( C-right right C-x ) C-x e e e ...

doesn't move point by words, only by characters.

This affects only arrow keys like `C-right' bound to `right-word'
in bindings.el.  I tested non-arrow keys like `M-f', and they work fine.

bug#17777: 24.3.91; Word motion commands are broken

[Eli Zaretskii]

> From: Juri Linkov <juri@jurta.org>
> Date: Sat, 14 Jun 2014 13:03:10 +0300
> 
> For testing I tried to set `visual-order-cursor-movement' to t
> and noticed that it breaks the word motion commands in keyboard macros.
> Steps to reproduce:
> 
> 0. emacs -Q
> 1. (setq visual-order-cursor-movement t)
> 2. (insert "word word word")
> 3. C-a C-x ( C-right right C-x ) C-x e e e ...
> 
> doesn't move point by words, only by characters.

Thanks, fixed in emacs-24 revision 117241.

bug#17777: 24.3.91; Word motion commands are broken

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

reopen 17777
thanks

>> For testing I tried to set `visual-order-cursor-movement' to t
>> and noticed that it breaks the word motion commands in keyboard macros.
>> Steps to reproduce:
>>
>> 0. emacs -Q
>> 1. (setq visual-order-cursor-movement t)
>> 2. (insert "word word word")
>> 3. C-a C-x ( C-right right C-x ) C-x e e e ...
>>
>> doesn't move point by words, only by characters.
>
> Thanks, fixed in emacs-24 revision 117241.

I kept this setting in ~/.emacs, and now noticed it not working
in another specific case:

0. emacs -Q
1. (progn
     (setq visual-order-cursor-movement t)
     (toggle-truncate-lines))
2. Insert a long line of e.g. (foobar) (foobar) (foobar) ...
3. Then try to adjust the window size to put the right window edge
   on the closing paren of one of these repeated strings (you may need
   to try different window widths before you could reproduce the bug)
4. Then put the cursor on the beginning of the test line
5. Now define and repeat the macro consisting of two keys:
   <C-M-right> (forward-sexp) and <right> (right-char)
6. When after repeating the macro with <C-x e> the cursor reaches
   the right window edge, then the cursor jumps to the second next line
   instead of doing the horizontal scrolling.

If it's difficult to reproduce this problem, this screenshot
might help you to see the window configuration where starting
to repeat the macro 9 times from the beginning of the foobars line
jumps to the line with the text “Macro:”


[-- Attachment #2: bug_17777.png --]
[-- Type: image/png, Size: 39448 bytes --]

bug#17777: 24.3.91; Word motion commands are broken

[Eli Zaretskii]

> From: Juri Linkov <juri@jurta.org>
> Date: Fri, 17 Jul 2015 02:04:00 +0300
> 
> 0. emacs -Q
> 1. (progn
>      (setq visual-order-cursor-movement t)
>      (toggle-truncate-lines))
> 2. Insert a long line of e.g. (foobar) (foobar) (foobar) ...
> 3. Then try to adjust the window size to put the right window edge
>    on the closing paren of one of these repeated strings (you may need
>    to try different window widths before you could reproduce the bug)
> 4. Then put the cursor on the beginning of the test line
> 5. Now define and repeat the macro consisting of two keys:
>    <C-M-right> (forward-sexp) and <right> (right-char)
> 6. When after repeating the macro with <C-x e> the cursor reaches
>    the right window edge, then the cursor jumps to the second next line
>    instead of doing the horizontal scrolling.

I couldn't reproduce this using the recipe you provided.  But here's a
much simpler recipe that is 100% reproducible: In step 2, insert a
single sexp that is longer than the window width, followed by some
text, for example:

  (foobar foobar foobar foobar foobar foobar foobar foobar foobar foobar foobar foobar foobar foobar foobar foobar) foo

Now step 3 is unnecessary, and the problem is clearly visible.

Btw, if your recipe is modified to insert an empty line after the
above sexp, then running the macro goes down by 2 lines, not by one.

I think I fixed this in commit a65e00b, please try.

bug#17777: 24.3.91; Word motion commands are broken

[Juri Linkov]

> Btw, if your recipe is modified to insert an empty line after the
> above sexp, then running the macro goes down by 2 lines, not by one.

Sorry, I meant just 2 lines, not one.

> I think I fixed this in commit a65e00b, please try.

Thank you, I tested and see no more problems, so closing this.