From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21435: 25.0.50; file-notify has problems after renames Date: Wed, 09 Sep 2015 20:15:09 +0200 Message-ID: <877fnzv4r6.fsf@gmx.de> References: <87y4gh47sr.fsf@gnu.org> <83k2s07vaf.fsf@gnu.org> <87fv2ovlcr.fsf@gmx.de> <83613k7owe.fsf@gnu.org> <87si6og17z.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441822585 2775 80.91.229.3 (9 Sep 2015 18:16:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Sep 2015 18:16:25 +0000 (UTC) Cc: 21435@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 09 20:16:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZZjul-0007T6-KV for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Sep 2015 20:16:11 +0200 Original-Received: from localhost ([::1]:44404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZjul-0004G3-0D for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Sep 2015 14:16:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZjuh-0004Fj-4s for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 14:16:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZjud-00057U-4g for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 14:16:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZjud-00057O-1G for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 14:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZZjuc-00051R-J0 for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2015 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2015 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21435-submit@debbugs.gnu.org id=B21435.144182251519241 (code B ref 21435); Wed, 09 Sep 2015 18:16:02 +0000 Original-Received: (at 21435) by debbugs.gnu.org; 9 Sep 2015 18:15:15 +0000 Original-Received: from localhost ([127.0.0.1]:54129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZjtq-00050G-Ik for submit@debbugs.gnu.org; Wed, 09 Sep 2015 14:15:15 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:63936) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZjtp-000508-0N for 21435@debbugs.gnu.org; Wed, 09 Sep 2015 14:15:13 -0400 Original-Received: from detlef.gmx.de ([87.146.52.139]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LvVYZ-1Yb03x1UUl-010ZP2; Wed, 09 Sep 2015 20:15:10 +0200 In-Reply-To: <87si6og17z.fsf@gnu.org> (Tassilo Horn's message of "Tue, 08 Sep 2015 21:28:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:TbfL9kpThNrnhYTJRVwSzbBAZmM9sZuqHslNDf18lj3HmcPCmr0 ErxKUC7wdj7W75zZ2i/0LmBm5dVEaJJWYJ7rYmC0KTxupphVJufWTiISA3xQrbjPnS7upwZ 1U7qaEapMVyOXqdGnz5O+klzl8dB3YHFPx7ycPGKIU7PSJr7etriyc1UgrXPptq+wAXEygd wu27fKo3IC2Gq4xLgWBfQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:TQPEXYl3Gag=:U/8rRq7wBMfQzrMZ5B34+B YnQ94QJMw4lVQiQI0772ENpUxDAVBnB+LrjRFVLLlaglOoYq4Yuar74aEFIuhDee3RqvbKMW9 HFutgAwsIrX73H0oW/lRrMQr8Z/tR3HE2ZNaRdhZlsekq7kJiprfoMzHw+9JzIMVYbNXp2woB OJn+SJXNpPqRt2cfriJoDMcLGLVxlC00IvdfNhcSbd1MWYqwoTbjl4sK2w/0g/O+Jz55CE6Ex DF1Yv7GXVErOSn8G6q3YVbfzvm1YhKzIukHRLUI4rtdYpcpdk/mRndhm7L4t/ZL/LP31VioV/ aYTMcIpbqaqFuemnNmuWZ44TFM3rK7APMrcvF7HyGCeHwENmK2p94HbWmt4ScYBUCXaEFVjmR GiZtdrD1CBqXKr6amoi94e0pLZq3cI9qV5bLzR/3z1FpBtObQNsnNsZ+WNvrMM8Zbk7/RtZ07 89wUBrbo5NFSZXG8FzLNVbCZy2SA9HY0SC91WmPBGy5aYgclxR5aaRbCcg4gRCH6ZDgDm+i3I qmlJvOR4aB1pAUl3UTgcYBPGRsvvicV9vJK6kyQiwzUvd2+/qSnG2nCjOkrzvNG90vPQYMond Ris9sx2ubeTzjHM9slFES9klUMOUXqWLnWrUVpeTIOQbRPJQr6fdiJG3OHQ4ZxbxOtX/RBZzx r2ODDWlFujLQEf+mSDVQ7gKyaqDBHXlwz9KMREIx7+gLQ8q6SL51ecZ1RRGmDYqEGjxi6zVTI XRa2SSNoGjn41OdIKOHeCKEIFGAeFY5pnDyn2Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106320 Archived-At: Tassilo Horn writes: >> But then Tassilo's "renames always seem to be reported twice" is >> inaccurate: this should only happen when a file is moved to another >> directory. > > See my other mail: the test if the source/target are different were done > by testing if the descriptors are not `eq' but since inotify descriptors > are conses, that test returned nil even though they were structurally > equal. Thanks for fixing this. I always had in mind that `file-notify--descriptor' returns the same object, and maybe it did even so in the past, but now it composes the cons itself. So we must test for `equal', indeed. >>> PS: Tassilo, you write great test cases. Do you want to contribute to >>> test/automated/file-notify-tests.el? > > Yes, but right now I can't because all these corner cases like the ones > from my last two reports are largely undocumented so I don't know what > to assert. I myself don't have a strong opinion on the behavior of > file-notify as long as it's consistent across the different > `file-notify--library' possibilities (at least mostly, e.g., I can live > with created/deleted events in place of renamed in case the backend > doesn't support this) and the documentation is a bit more definite. Even the straigt forward cases are not covered well in file-notify-tests.el. There is a test whether events arrive, but the nature of the events is not asserted. You could try with what you expect, at least for inotify, and Eli and I could check then for the gfilenotify and w32notify cases. If we have the same results, fine; if we have different results it would be a good chance for us to harmonize. And starting with inotify is also good because this is the library used on hydra. We do not want to make Glenn sad because of failed tests. >>> PPS: Forgive me slow progress; I'm still suffering from health >>> problems. >> >> Wish you to recover quickly. > > Ditto! Won't happen, unfortunately. It still takes months. > Bye, > Tassilo Best regards, Michael.