From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Suggestion to have highlight related bindings consistent between search-map and hi-lock-map Date: Fri, 05 Feb 2016 02:54:32 +0200 Organization: LINKOV.NET Message-ID: <877fik2blb.fsf@mail.linkov.net> References: <874mlaearx.fsf@mail.linkov.net> <55A21229.6080903@gmail.com> <55A27E53.7020605@gmail.com> <834ml99zkp.fsf@gnu.org> <831tgd9wcm.fsf@gnu.org> <55AB58FB.8000501@gmail.com> <87r3nqk34p.fsf@mail.linkov.net> <878u96yl2o.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454635756 5341 80.91.229.3 (5 Feb 2016 01:29:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Feb 2016 01:29:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 05 02:29:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRVCr-0004dm-BT for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 02:29:05 +0100 Original-Received: from localhost ([::1]:45233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRVCq-0005ZP-EK for ged-emacs-devel@m.gmane.org; Thu, 04 Feb 2016 20:29:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRVCl-0005T9-LO for emacs-devel@gnu.org; Thu, 04 Feb 2016 20:29:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRVCk-00020l-Ql for emacs-devel@gnu.org; Thu, 04 Feb 2016 20:28:59 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:58915 helo=homiemail-a15.g.dreamhost.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRVCk-00020a-KK for emacs-devel@gnu.org; Thu, 04 Feb 2016 20:28:58 -0500 Original-Received: from homiemail-a15.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTP id 21A1676C065; Thu, 4 Feb 2016 17:28:57 -0800 (PST) Original-Received: from localhost.linkov.net (85.253.170.183.cable.starman.ee [85.253.170.183]) (Authenticated sender: jurta@jurta.org) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTPA id 4116E76C069; Thu, 4 Feb 2016 17:28:56 -0800 (PST) In-Reply-To: (Kaushal Modi's message of "Tue, 02 Feb 2016 20:45:19 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 69.163.253.7 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199343 Archived-At: > Here are my reasons to remove the "C-x w" map: > - The bindings are inconsistent between the "M-s h" and "C-s w" maps. > - In addition to confusion, the bindings are also duplicated in two prefix > maps. > - Also if we remove this prefix map today, we will have lesser number of > disappointed users than when and if it is removed in the future. > > Here is the piece from earlier in this thread where I compared the > inconsistent bindings (the line numbers can be ignored as they might not be > the same today): > > hi-lock.el 277: (define-key map "\C-xwi" 'hi-lock-find-patterns) > bindings.el 935: (define-key search-map "hf" 'hi-lock-find-patterns) > > hi-lock.el 282: (define-key map "\C-xwr" 'unhighlight-regexp) > bindings.el 934: (define-key search-map "hu" 'unhighlight-regexp) > > hi-lock.el 280: (define-key map "\C-xwh" 'highlight-regexp) > bindings.el 930: (define-key search-map "hr" 'highlight-regexp) > > hi-lock.el 283: (define-key map "\C-xwb" > 'hi-lock-write-interactive-patterns) > bindings.el 936: (define-key search-map "hw" > 'hi-lock-write-interactive-patterns) > > The source of this discussion is because I kept getting confused if I need > to do "M-s h r" or "C-x w r" to highlight a regexp. So after a point, I > bound C-x w to nil to solve the problem. > > That made me think that this topic should also be brought up in this thread > and have this fixed directly in the source. Maybe conducting a poll will help to see how many users will be disappointed.