From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.help Subject: Re: Help setting nadvice for indent-region Date: Fri, 12 Feb 2016 14:57:26 +0100 Message-ID: <877fiadoah.fsf@web.de> References: <87a8ne2k6v.fsf@web.de> <87bn7n15ki.fsf@web.de> <87vb5vys7n.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455285484 32272 80.91.229.3 (12 Feb 2016 13:58:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Feb 2016 13:58:04 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Feb 12 14:57:55 2016 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aUEEM-00013J-9i for geh-help-gnu-emacs@m.gmane.org; Fri, 12 Feb 2016 14:57:54 +0100 Original-Received: from localhost ([::1]:32797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUEEL-0001n5-NQ for geh-help-gnu-emacs@m.gmane.org; Fri, 12 Feb 2016 08:57:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUEEB-0001mr-7q for help-gnu-emacs@gnu.org; Fri, 12 Feb 2016 08:57:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUEE8-0008Gd-24 for help-gnu-emacs@gnu.org; Fri, 12 Feb 2016 08:57:43 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:39810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUEE7-0008Fz-Qa for help-gnu-emacs@gnu.org; Fri, 12 Feb 2016 08:57:39 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aUEE3-0000oe-Iu for help-gnu-emacs@gnu.org; Fri, 12 Feb 2016 14:57:35 +0100 Original-Received: from dslb-092-074-178-250.092.074.pools.vodafone-ip.de ([92.74.178.250]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Feb 2016 14:57:35 +0100 Original-Received: from michael_heerdegen by dslb-092-074-178-250.092.074.pools.vodafone-ip.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Feb 2016 14:57:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: dslb-092-074-178-250.092.074.pools.vodafone-ip.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) Cancel-Lock: sha1:M++MX68FCBaBVcVl4l2PWcTaQfI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:109133 Archived-At: Kaushal Modi writes: > Things became clear after I added this debug statement: > > (message "Args: %S use-region-p: %S" args (use-region-p)) > > In any case, I will be going the right way of advising this as Stefan > and you advised. Now I only need to figure out how not to print that > message when doing eval-defun. If it's only for debugging anyway, and you want to message that only when your advice comes into play, I suggest to move that call to the interactive part as well. > > The around advice function should return the value you want the > > advised function > to return. > > Thank you! So with a let-bound variable 'ret', I can have something like > > (setq ret (apply orig-fn args)) > > and return 'ret' at the end of the :around advice function definition. > Right? Sure. It's just a matter of style (i.e. a more functional vs. a more imperative programming style). Regards, Michael.