bug#22721: Make the eww-font-toggle message clear

bug#22721: Make the eww-font-toggle message clear

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

Hi,

Here's a little patch where I change things a little bit in eww-font-toggle
function.

(1) The message is printed *after* eww-reload so that the font message is
not quickly masked by the "Contacting host.." message put out by
eww-reload. That way it is more obvious to the user if the proportional
fonts were turned on or off.

(2) Instead of "Fonts are now .." message, it now prints "Proportional
fonts are now ..". Earlier, I was confused if the monospace fonts were on
or proportional fonts were on. Doing "C-h v shr-use-fonts" helped me
understand that message better.

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index da920c1..8536c63 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1498,11 +1498,11 @@ eww-set-character-encoding
 (defun eww-toggle-fonts ()
   "Toggle whether to use monospaced or font-enabled layouts."
   (interactive)
-  (message "Fonts are now %s"
+  (eww-reload)
+  (message "Proportional fonts are now %s"
    (if (setq shr-use-fonts (not shr-use-fonts))
        "on"
-     "off"))
-  (eww-reload))
+     "off")))

 ;;; Bookmarks code





--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1842 bytes --]

bug#22721: Make the eww-font-toggle message clear

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Made a "duh" mistake in my earlier patch.

Here's the fixed version:

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index da920c1..185b9e6 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1498,11 +1498,10 @@ eww-set-character-encoding
 (defun eww-toggle-fonts ()
   "Toggle whether to use monospaced or font-enabled layouts."
   (interactive)
-  (message "Fonts are now %s"
-   (if (setq shr-use-fonts (not shr-use-fonts))
-       "on"
-     "off"))
-  (eww-reload))
+  (setq shr-use-fonts (not shr-use-fonts))
+  (eww-reload)
+  (message "Proportional fonts are now %s"
+   (if shr-use-fonts "on" "off")))

 ;;; Bookmarks code





--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1337 bytes --]

bug#22721: Make the eww-font-toggle message clear

[Lars Ingebrigtsen]

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Here's the fixed version:

Thanks; applied to emacs-25.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no