Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Alex]

As per the title, orgtbl-mode doesn't overwrite whitespace in tables
like it does normally in org-mode. Backspace works as expected, however.

This was produced in emacs -Q in fundamental-mode.

Emacs  : GNU Emacs 24.5.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.18.9)
 of 2016-04-11 on buildvm-25.phx2.fedoraproject.org
Package: Org-mode version 8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)

current state:
==============
(setq
 org-tab-first-hook '(org-hide-block-toggle-maybe
		      org-babel-hide-result-toggle-maybe
		      org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook
			  org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-show-block-all
		    append local]
		   5]
		 #[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook
		    org-babel-show-result-all append local]
		   5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
			  org-babel-execute-safely-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
		  org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )

Re: Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Alex]

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

> Backspace works as expected, however.
I'm afraid that as of org-20160516 on ELPA, backspace also does not
overwrite whitespace.

Re: Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Alex G]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

> > Backspace works as expected, however.
> I'm afraid that as of org-20160516 on ELPA, backspace also does not
> overwrite whitespace.


Oh, it seems like backspace works fine in text modes like
fundamental-mode and message-mode, but not prog-derived modes. I'd say
that's another bug.

A git bisect says that this commit by Bastien Guerry is the culprit:
f0a64ab3b5c46c8c7b1c838de2ed20511357e43d

Does anyone know why it also affects orgtbl-self-insert-command?

[-- Attachment #2: Type: text/html, Size: 546 bytes --]

Re: Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Alex]

Alex G <agrambot@gmail.com> writes:

>> > Backspace works as expected, however.
>> I'm afraid that as of org-20160516 on ELPA, backspace also does not
>> overwrite whitespace.
>
> Oh, it seems like backspace works fine in text modes like
> fundamental-mode and message-mode, but not prog-derived modes. I'd say
> that's another bug.
>
> A git bisect says that this commit by Bastien Guerry is the culprit:
> f0a64ab3b5c46c8c7b1c838de2ed20511357e43d
>
> Does anyone know why it also affects orgtbl-self-insert-command?

I believe I have figured out the issue for both problems:

a) orgtbl-self-insert-command wasn't updated along with
org-self-insert-command in the commit
73a5c27cc1751721344886e7518f20ff382265b5. Changing it accordingly fixes
the issue.


b) Backspace doesn't work in prog-derived modes as orgtbl-mode seems to
just remap delete-backward-char to orgtbl, but in prog modes backspace
is bound to backward-delete-char-untabify.

Perhaps something extra should be done about backspace in orgtbl-mode
instead of just a simple remapping?

Re: Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Nicolas Goaziou]

Hello,

Alex <agrambot@gmail.com> writes:

> As per the title, orgtbl-mode doesn't overwrite whitespace in tables
> like it does normally in org-mode.

Fixed. Thank you.


Regards,

-- 
Nicolas Goaziou

Re: Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Nicolas Goaziou]

Hello,

Alex G <agrambot@gmail.com> writes:

> Oh, it seems like backspace works fine in text modes like
> fundamental-mode and message-mode, but not prog-derived modes. I'd say
> that's another bug.
>
> A git bisect says that this commit by Bastien Guerry is the culprit:
> f0a64ab3b5c46c8c7b1c838de2ed20511357e43d

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Alex]

Hello,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Alex G <agrambot@gmail.com> writes:
>
>> Oh, it seems like backspace works fine in text modes like
>> fundamental-mode and message-mode, but not prog-derived modes. I'd say
>> that's another bug.
>>
>> A git bisect says that this commit by Bastien Guerry is the culprit:
>> f0a64ab3b5c46c8c7b1c838de2ed20511357e43d
>
> Fixed. Thank you.
>
> Regards,

Thank you for the fixes. However, the fix in 4914f89 does not work for
me. When I run it (type backspace) in a graphical Emacs I get:

user-error: This key has no function outside tables

When I run it in a terminal Emacs the command is not rebound at all.

Replacing [(del)] with (kbd "DEL") fixed the issue for me.

Re: Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

[Nicolas Goaziou]

Hello,

Alex <agrambot@gmail.com> writes:

> Thank you for the fixes. However, the fix in 4914f89 does not work for
> me. When I run it (type backspace) in a graphical Emacs I get:
>
> user-error: This key has no function outside tables
>
> When I run it in a terminal Emacs the command is not rebound at all.
>
> Replacing [(del)] with (kbd "DEL") fixed the issue for me.

Done. Thank you.

Regards,

-- 
Nicolas Goaziou