From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Benjamin Riefenstahl Newsgroups: gmane.emacs.bugs Subject: bug#22434: 25.0.50; recentf pastes X clipboard upon opening Date: Sun, 22 May 2016 21:12:51 +0200 Message-ID: <877fel9aa4.fsf@blei.turtle-trading.net> References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1463944472 31549 80.91.229.3 (22 May 2016 19:14:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 May 2016 19:14:32 +0000 (UTC) Cc: 22434@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 22 21:14:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b4YoP-0006YK-Lr for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 May 2016 21:13:19 +0200 Original-Received: from localhost ([::1]:44351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4YoO-0002de-MQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 May 2016 15:13:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4YoG-0002dL-Aa for bug-gnu-emacs@gnu.org; Sun, 22 May 2016 15:13:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4YoA-0007xN-IO for bug-gnu-emacs@gnu.org; Sun, 22 May 2016 15:13:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4YoA-0007xJ-Ek for bug-gnu-emacs@gnu.org; Sun, 22 May 2016 15:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b4YoA-00078L-55 for bug-gnu-emacs@gnu.org; Sun, 22 May 2016 15:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Benjamin Riefenstahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 May 2016 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 22434-submit@debbugs.gnu.org id=B22434.146394438127414 (code B ref 22434); Sun, 22 May 2016 19:13:02 +0000 Original-Received: (at 22434) by debbugs.gnu.org; 22 May 2016 19:13:01 +0000 Original-Received: from localhost ([127.0.0.1]:33044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4Yo8-000786-Op for submit@debbugs.gnu.org; Sun, 22 May 2016 15:13:00 -0400 Original-Received: from odoacer.turtle-trading.net ([217.91.34.180]:39496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4Yo6-00077s-VB for 22434@debbugs.gnu.org; Sun, 22 May 2016 15:12:59 -0400 Original-Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b4Ynz-00075b-7G; Sun, 22 May 2016 21:12:51 +0200 Original-Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b4Ynz-0004MF-4I; Sun, 22 May 2016 21:12:51 +0200 In-Reply-To: <83wpmm57be.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 May 2016 20:30:29 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118542 Archived-At: > From: Benjamin Riefenstahl >> From where does the come here? Eli Zaretskii writes: > See below: > >> @@ -112,7 +111,7 @@ mouse--down-1-maybe-follows-link >> timedout (not timedout)) >> nil >> >> - (let ((event (read-event))) >> + (let ((event (read-key))) ;Use read-key so it works for xterm-mouse-mode! >> (if (eq (car-safe event) (if (eq mouse-1-click-follows-link 'double) >> 'double-mouse-1 'mouse-1)) >> ;; Turn the mouse-1 into a mouse-2 to follow links. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Which continues: > > (let ((newup (if (eq mouse-1-click-follows-link 'double) > 'double-mouse-2 'mouse-2))) Right. I also see now that bug #23288 had a solution, but it does not work for me in this case. It depends on mouse-on-link-p to return a string or a vector, but what I get at this point is just t. Inside mouse-on-link-p the first branch of the cond is taken, because the follow-link property is 'mouse-face. This whole translation business seems fishy to me. There is no check that the cursor or at least the window are still the same when the mouse-2 handler is eventually called (it isn't here, I believe). There is no check that mouse-2 is actually bound to anything meaningfull that we want in addition to the mouse-1 handler. And what is the formal definition of 'meaningfull' here? And why is there a need to fall back to a mouse-2 handler when there is an explicit handler for mouse-1 already, widget-button-click in this case? Let the mouse-1 handler do what it wants to have done.