From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#23478: 25.0.93; Mouse region selection asymmetry Date: Mon, 04 Jul 2016 20:26:59 +0200 Message-ID: <877fd16yz0.fsf@gmx.net> References: <878tzky2oe.fsf@gmx.net> <83eg9cecy2.fsf@gnu.org> <87wpn4wgev.fsf@gmx.net> <8360uoe5ye.fsf@gnu.org> <87shxswd5s.fsf@gmx.net> <834ma8e3ll.fsf@gnu.org> <871t3bhbpz.fsf@users.sourceforge.net> <87poqun63w.fsf@gmx.net> <83furqratc.fsf@gnu.org> <87h9c6mkb0.fsf@gmx.net> <83vb0mp1ok.fsf@gnu.org> <87wpl17pvs.fsf@gmx.net> <83eg79pi29.fsf@gnu.org> <87bn2d736k.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467656908 13578 80.91.229.3 (4 Jul 2016 18:28:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Jul 2016 18:28:28 +0000 (UTC) Cc: 23478@debbugs.gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 04 20:28:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bK8bQ-0000aL-9P for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2016 20:28:16 +0200 Original-Received: from localhost ([::1]:49793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK8bP-0005Jj-JH for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2016 14:28:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK8bJ-0005HF-OS for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2016 14:28:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bK8bD-0003Si-0S for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2016 14:28:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK8bC-0003Se-Tm for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2016 14:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bK8bC-0000mT-Gx for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2016 14:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2016 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23478-submit@debbugs.gnu.org id=B23478.14676568432955 (code B ref 23478); Mon, 04 Jul 2016 18:28:02 +0000 Original-Received: (at 23478) by debbugs.gnu.org; 4 Jul 2016 18:27:23 +0000 Original-Received: from localhost ([127.0.0.1]:37387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bK8aY-0000lb-RS for submit@debbugs.gnu.org; Mon, 04 Jul 2016 14:27:22 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:63889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bK8aX-0000lN-6X for 23478@debbugs.gnu.org; Mon, 04 Jul 2016 14:27:21 -0400 Original-Received: from rosalinde ([89.245.65.175]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LdLw5-1bkdlP1J5d-00iUbt; Mon, 04 Jul 2016 20:27:02 +0200 In-Reply-To: <87bn2d736k.fsf@gmx.net> (Stephen Berman's message of "Mon, 04 Jul 2016 18:56:03 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:PoQEF4CR2XlJTnfCrJcRZwbTCZQmxnVQnxZrsFwQVQYqKotoSr8 x9rv/jncC2RryaJoXr5uKINlRfn/0gAmdToAAV5yzKV5P/ywI/2lTEOtDRETfj11bYx4xnH oQLxj+Ecupt98D+SXfCsIJB93Ohz06GqDTv3C8c83o7GEKjWsIbOrObOkTMnYmOGMkCVi1n eS+wRymM7AmM2oDFIPUVg== X-UI-Out-Filterresults: notjunk:1;V01:K0:aU5Drsx4QhA=:SXxnlE8z7k2lZS1YAogC/D YXYwXypVEQdEDggvwip8LUmY7yMCA3zGdiCKc48d8FQZwBPKkC/wj8Lt3tVesR2VpPW0rzkKk 8v8TiLa+KpwYalZZc0HZFKqh+zMgQZZAhPUc8JgxOCrI0QssPSUBOs+5DkALcf3Lqrw967Cq+ BLeaHOs8AVE/3gAnJChmvhfM91TdCexL+OXWG/fZgqz2CPIV4fn0zNLYZ+gXgx9QrsMgPdpw/ ai/xJ4swREplpsuyznZAupphe4vvVJlD+r8rWZz8SqKvOzp5khBVn7kvqUXe31NNqdnLUO7nQ qnCL7+/yG5itfyBP4sG3H/T15o/ENKpFhsnl1Y9y7jkL2ka0cx/u03WCkCzces9/YQV3x9jh7 aoudNxLmuWXa55wlQtuGVONKo73CThdKm4bHRVHg49f3XQfpUxX0Mpn2IJ0/DZ/rzP9fQpzV2 dxrbHhhVhW1P2PKTSWnPfW3/E/osn9CZ9sWkuySjQi2FR1FvNc4d9K3CU0VNtOgAirR0YSPqH BXkAlcOsdc3LwlJ1ZlzTQ27BbBOCLGhKV4k5OjprTy/RCYtRrRzy/OrGO0uQGQo3ru2TsWsB8 8t+pnpqXPNVHGDHaABJNt1bEpioMRKE8TDSRLLPFts7ZlQ0d2rqaKN+KtFkeylaCuw2EFCvDN oRSgXvEjfA6CaLitt1MpAWdeK0xLUXIpRBRsAZsPReP9rAt9/ptyv8CDYwWCf0xoXMwG9ym4e YVBZtVssri5iv0fQfinEIkBQ6dDv2WZkBRVKm/1IrE2E8zlCFDeP+OCHxwukYoUxR6IDQYw5 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120416 Archived-At: On Mon, 04 Jul 2016 18:56:03 +0200 Stephen Berman wrote: > diff --git a/lisp/mouse.el b/lisp/mouse.el > index 8d72753..39adc42 100644 > --- a/lisp/mouse.el > +++ b/lisp/mouse.el > @@ -548,7 +548,11 @@ mouse-set-point > (interactive "e\np") > (mouse-minibuffer-check event) > (if (and promote-to-region (> (event-click-count event) 1)) > - (mouse-set-region event) > + (progn > + (mouse-set-region event) > + (when (> (window-start) (region-beginning)) > + (exchange-point-and-mark) > + (sit-for 0))) > ;; Use event-end in case called from mouse-drag-region. > ;; If EVENT is a click, event-end and event-start give same value. > (posn-set-point (event-end event)))) > > This makes the bevavior even more like the first situation (i.e., the > mirror image of it). So I like this solution even better. What do you > think? That patch only mirrors the first situation when the region begins above the window; the following always changes point when clicking at what will be the end point of the region, so this fully mirrors the first situation, and would be the most symmetrical behavior (unless I'm overlooking something): diff --git a/lisp/mouse.el b/lisp/mouse.el index 8d72753..608a52f 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -548,7 +548,11 @@ mouse-set-point (interactive "e\np") (mouse-minibuffer-check event) (if (and promote-to-region (> (event-click-count event) 1)) - (mouse-set-region event) + (progn + (mouse-set-region event) + (when (> (posn-point (event-start event)) (region-beginning)) + (exchange-point-and-mark) + (sit-for 0))) ;; Use event-end in case called from mouse-drag-region. ;; If EVENT is a click, event-end and event-start give same value. (posn-set-point (event-end event)))) Steve Berman