From: Nicolas Petton <nicolas@petton.fr>
To: Eli Zaretskii <eliz@gnu.org>, rediesmatthias@yahoo.de
Cc: 21598@debbugs.gnu.org, 21598-done@debbugs.gnu.org
Subject: bug#21598: 24.5; Auto-revert-mode loads images as text
Date: Mon, 25 Jul 2016 23:42:26 +0200 [thread overview]
Message-ID: <877fc9s8cd.fsf@petton.fr> (raw)
In-Reply-To: <83h9ma8jaz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Actually, I see that image-mode installs an after-revert-hook, bit the
> hook function, image-after-revert-hook, does nothing in this case
> because image-get-display-property returns nil.
It seems to return nil because `revert-buffer' is called with is called
with `preserve-modes' set to non-nil, so `image-mode' is not called
again, so `image-toggle-display-image' is never called on the updated
buffer.
I installed a fix in master, commit b176d16.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
prev parent reply other threads:[~2016-07-25 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 15:17 bug#21598: 24.5; Auto-revert-mode loads images as text Matthias Redies
2015-10-01 19:01 ` Eli Zaretskii
2015-10-01 19:45 ` Eli Zaretskii
2016-07-25 21:42 ` Nicolas Petton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fc9s8cd.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=21598-done@debbugs.gnu.org \
--cc=21598@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rediesmatthias@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.