From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: RE: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter. Date: Tue, 02 Aug 2016 00:48:33 +0200 Message-ID: <877fc0cdha.fsf@petton.fr> References: <20160728174955.13840.3558@vcs.savannah.gnu.org> <20160728174955.752F622016B@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1470091758 14422 195.159.176.226 (1 Aug 2016 22:49:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 Aug 2016 22:49:18 +0000 (UTC) User-Agent: Notmuch/0.21 (https://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Cc: Vincent =?utf-8?Q?Bela=C3=AFche?= To: Vincent =?utf-8?Q?Bela=C3=AFche?= , John Wiegley , "emacs-devel\@gnu.org" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 02 00:49:13 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUM1J-0003SZ-G3 for ged-emacs-devel@m.gmane.org; Tue, 02 Aug 2016 00:49:13 +0200 Original-Received: from localhost ([::1]:53139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUM1F-0005Hx-SY for ged-emacs-devel@m.gmane.org; Mon, 01 Aug 2016 18:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUM19-0005GT-J5 for emacs-devel@gnu.org; Mon, 01 Aug 2016 18:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUM13-0004fv-3s for emacs-devel@gnu.org; Mon, 01 Aug 2016 18:49:02 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:49852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUM11-0004eV-TK for emacs-devel@gnu.org; Mon, 01 Aug 2016 18:48:57 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D3E7F2066E; Mon, 1 Aug 2016 18:48:47 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 01 Aug 2016 18:48:47 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=XO5tJMM1QhzCAJtHJdHNBlggm3c=; b=MrBp2 5+5bedPEm4+6G+oV79WEAZg6pQD/loEXlRFyePHNuEFpahj1k4IMNXIHMJkI7Qk7 etWi9ZHtySqEsRlFIp76i5IkGaGjdLjvBKi9zD4i/Vh9h3KF7SYEH/g8/XamYlxN Tm2UC23GzKh49wn6ZfM++AYyGmpeUZ/pf/VjN4= X-Sasl-enc: lq8mNDxnVpytvfaroxtZLJqsGldt44q7TtgtKxN8SUJ5 1470091727 Original-Received: from strawberry (lfbn-1-7726-61.w92-167.abo.wanadoo.fr [92.167.139.61]) by mail.messagingengine.com (Postfix) with ESMTPA id 12B27F29DC; Mon, 1 Aug 2016 18:48:46 -0400 (EDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206336 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Vincent Bela=C3=AFche writes: > Well, I must admit that I am a naughty boy that has not filed any bug > before making this fix. I of course did some basic tests before > comitting and it was OK. Hi Vincent, The purpose of a release candidate is to provide a tarball as close as possible to the final release for testing, so once the first RC is out, only critical bug fixes should be pushed to the release branch. If a particular bug is blocking the release, then it's of course ok to commit a fix for it on emacs-25, but since it's not the case here, I think that commits 8a38e94 and 3c97b0f should have been pushed to master instead. > IMHO taking this bug fix is not risky and that would make the local > printer feature more complete. I understand that, but who knows, even if your commit looks safe it might still introduce issues that you haven't seen yet :-) Cheers, Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: GPGTools - http://gpgtools.org iQEcBAEBCAAGBQJXn9HBAAoJECM1h6R8IHkQNFgH+wUpUJt0c7NBv5S8cHK73+Vf iyx2i6vazS6EgyVCrH9p9w1jX9ylfWgCxOD62WUguWFQbzWiCsAaqYZRiwz+ApVv mRSpmc8/HG1F8sCZQDb5TAoEkhuToRUNBf5Q46pIkpwAsRbP3XU3Hz4HLwxSnHjg H/ECY+0zKWxOONRsQ3OdMBmSOTIuwe3txEzVvP/tYE2lavI4cA/E0WR2OSVtAAJR O9OZ7FSm326PpRTGqV/wxwnev5AKYozHcF0Ix+OGKX7AXwsweH3hl/OHWSgVcBbS Z+CAauEm1GbFYse8JStpZFkI20tcOcUerUSF6HSYiRXaTTnY7kZK5ccASNnl0mQ= =mYmd -----END PGP SIGNATURE----- --=-=-=--