From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.
Date: Wed, 07 Sep 2016 20:25:07 +0200 [thread overview]
Message-ID: <877fank1oc.fsf@toke.dk> (raw)
In-Reply-To: <83bmzzaawr.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Sep 2016 20:15:48 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Toke Høiland-Jørgensen <toke@toke.dk>
>> Date: Wed, 07 Sep 2016 18:52:15 +0200
>> Cc: emacs-devel@gnu.org
>>
>> Right, well, I'm not actually sure that there's any multibyte *content*
>> in the cookie header. But somehow, without this patch, if there's an
>> UTF-8 payload, (string-bytes request) returns an extra byte for each
>> UTF-8 octet. I have no idea why that is; basically, what I would see was:
>>
>> (string-bytes url-http-data) == (length url-http-data)
>>
>> but
>>
>> (string-bytes (substring request (* -1 (length (url-http-data))))) being
>> two bytes longer (for a single UTF-8 character in the payload).
>
> Can you show a test case where this happens?
Appears to be any request with an UTF-8 encoded payload that goes
to a host that has cookies stored.
This snippet triggers the error for me if I replace example.org with a
domain that has cookies stored in ~/.emacs.d/url/cookies:
(let* ((url-request-data (encode-coding-string "æøå" 'utf-8)))
(url-retrieve-synchronously "http://example.org"))
-Toke
next prev parent reply other threads:[~2016-09-07 18:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 15:30 [PATCH] url: Wrap cookie headers in url-http--encode-string Toke Høiland-Jørgensen
2016-09-07 16:40 ` Stefan Monnier
2016-09-07 16:52 ` Toke Høiland-Jørgensen
2016-09-07 17:15 ` Eli Zaretskii
2016-09-07 18:25 ` Toke Høiland-Jørgensen [this message]
2016-09-08 14:06 ` Dmitry Gutov
2016-09-08 14:14 ` Toke Høiland-Jørgensen
2016-09-08 14:25 ` Dmitry Gutov
2016-09-08 15:58 ` Toke Høiland-Jørgensen
2016-09-08 17:20 ` Eli Zaretskii
2016-09-08 17:43 ` Toke Høiland-Jørgensen
2016-09-08 18:01 ` Eli Zaretskii
2016-09-08 17:47 ` Stefan Monnier
2016-09-08 18:04 ` Eli Zaretskii
2016-09-08 20:29 ` Alain Schneble
2016-09-09 7:57 ` Eli Zaretskii
2016-09-09 14:56 ` Alain Schneble
2016-09-09 15:04 ` Eli Zaretskii
2016-09-09 15:16 ` Alain Schneble
2016-09-09 15:06 ` Stefan Monnier
2016-09-09 15:15 ` Alain Schneble
2016-09-09 18:02 ` Alain Schneble
2016-09-09 18:07 ` Toke Høiland-Jørgensen
2016-09-09 18:54 ` Eli Zaretskii
2016-09-09 19:21 ` Alain Schneble
2016-09-09 19:32 ` Eli Zaretskii
2016-09-09 19:47 ` Alain Schneble
2016-09-09 19:49 ` Eli Zaretskii
2016-09-09 19:56 ` Toke Høiland-Jørgensen
2016-09-10 5:42 ` Eli Zaretskii
2016-09-10 8:34 ` Dmitry Gutov
2016-09-10 19:12 ` Eli Zaretskii
2016-09-09 20:01 ` distinguishing multibyte/unibyte ASCII (was: [PATCH] url: Wrap cookie headers in url-http--encode-string.) Stefan Monnier
2016-09-09 20:17 ` distinguishing multibyte/unibyte ASCII Toke Høiland-Jørgensen
2016-09-09 20:46 ` Stefan Monnier
2016-09-09 21:02 ` Alain Schneble
2016-09-10 5:50 ` distinguishing multibyte/unibyte ASCII (was: [PATCH] url: Wrap cookie headers in url-http--encode-string.) Eli Zaretskii
2016-09-07 19:14 ` [PATCH] url: Wrap cookie headers in url-http--encode-string Lars Ingebrigtsen
2016-09-07 20:49 ` Toke Høiland-Jørgensen
2016-09-08 2:47 ` Eli Zaretskii
2016-09-08 9:07 ` Lars Ingebrigtsen
2016-09-08 17:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fank1oc.fsf@toke.dk \
--to=toke@toke.dk \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.