bug#24455: 25.1.50; No error if --with-imagemagick not obeyed

bug#24455: 25.1.50; No error if --with-imagemagick not obeyed

[Óscar Fuentes]

If we require ImageMagick support with --with-imagemagick and no usable
Imagemagick is found, the configuration will carry on.

IMO if the user requires a feature and that requirement can't be obeyed,
an error should be thrown and configuration should stop.


In GNU Emacs 25.1.50.7 (x86_64-pc-linux-gnu, X toolkit)
 of 2016-09-08 built on qcore
Repository revision: 3b3bc36b0d0b273534cf08a51d6a10c015875e2c
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
System Description:	Ubuntu 16.04.1 LTS

bug#24455: 25.1.50; No error if --with-imagemagick not obeyed

[Lars Ingebrigtsen]

Óscar Fuentes <ofv@wanadoo.es> writes:

> If we require ImageMagick support with --with-imagemagick and no usable
> Imagemagick is found, the configuration will carry on.
>
> IMO if the user requires a feature and that requirement can't be obeyed,
> an error should be thrown and configuration should stop.

Makes sense to me.

I've now changed it so that you get

./configure --with-imagemagick
[...]
checking for Wand >= 6.3.5 Wand != 6.8.2... no
configure: error: ImageMagick wanted, but it does not compile.  Maybe some library files are missing?

if you don't have the ImageMagick libraries.  If you don't say
--with-imagemagick, you should be unaffected.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no