From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Tue, 18 Oct 2016 14:32:07 +0200 Message-ID: <877f95deig.fsf@gmx.de> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1476794370 12523 195.159.176.226 (18 Oct 2016 12:39:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2016 12:39:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , Dmitry Gutov , emacs-devel@gnu.org To: Nikolay Kudryavtsev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 18 14:39:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwTfk-00013u-9l for ged-emacs-devel@m.gmane.org; Tue, 18 Oct 2016 14:39:12 +0200 Original-Received: from localhost ([::1]:41220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwTfm-0004DI-D7 for ged-emacs-devel@m.gmane.org; Tue, 18 Oct 2016 08:39:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwTZ4-0008IQ-T6 for emacs-devel@gnu.org; Tue, 18 Oct 2016 08:32:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwTZ1-0003rj-M6 for emacs-devel@gnu.org; Tue, 18 Oct 2016 08:32:18 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:52102) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwTZ1-0003mQ-Ct; Tue, 18 Oct 2016 08:32:15 -0400 Original-Received: from detlef.gmx.de ([87.146.53.123]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LyS5K-1cz2UQ2Hyw-015rI8; Tue, 18 Oct 2016 14:32:08 +0200 In-Reply-To: <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> (Nikolay Kudryavtsev's message of "Tue, 18 Oct 2016 14:59:42 +0300") X-Provags-ID: V03:K0:sKL7x4bx9jqFZrAts3LQF+b0KVWfpEpnXasbswfWbDQkVwyvKIq VjS0r1EST4tcJizWD2msa+cdhv37KuLUAMoSkmshSiU6VBIWn3EIE5xK2Ak95IG+W0w7nM+ /rdoiDxwQwx+HL/awStlQCt13V0g+ta2P9gmag4EPENwcbwLVucuUV52XLrUUTyW1PBkMhR n3Of1gdKFUJ4KeON8BauA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Se0C0xtln2Y=:sM2OYntj2Y3chH6oWPZfcV yDPws/hFrI3yhAQJ8/OdVtiDoUAxuFO/Am2wcc00vpVXDWrvSVQVgl9uaNUAm9k4X7rG7Hoi9 uvb1zrHgVjU4jf/dRHDIYerO41rk+SADc6rvOjzi9BWQgAA0gww4+J5MrDw+Hw35dba3smOxj wNhhTjLLVV/qhOn0rAj0ktrB4gs0q/qDukH3UoBvtTcNL9vb+cDBmsi15GbpwQtdnBemJEorW RlGcQ64LvPISSZ+0cb115qgFlaEw7o97rlyDZSQCbtlqrlITsQMi1lvbKV6nMyu/Kj3MTH5Oq X1gh7Mpk3ix5JOw0ZoPawinXnlZc3hyuc3X82cg3Tr2vVi9fcp6kO/r+cmcIe56aYAz8Twtco AeI+CN/XGdfwkbdJcN9x0UUnrukH4xUjrJe8qtQnvQA4BAW29rducQRKMYKOCZWvD3FRyNBNK tvwUFEr0qoBOTXtkDNkNLuzZqzLtB0mOo4zz+fuIatYL2lNeeJ03E7zArYNJ/TUCPDzF4khSL Gvz4sRG5o1elnYOu6amLzQXJwZ8iIBV7yAXXrESBNgkQdI/5tF+weshAaM3uHO0ihwW7to7zV wkz1Mg+89H06On5+DHIV2VKrdnoeKzC8/i1xpPvCD6YcYa59Q/APZbObyBLRuebs3IQnRKZhY ZK1kM0HIBn1YmYXqIEhZ/qiYLppl8SYVkNhlIFnCfEUf3VyQ3mfh7zSxto1mYvfT7LUpBoVzm r/tOAqZXGUldyw/ySTmAppwi/PlRpfYLCbKWlgSV5Mq7HefbinhrZ/d0TmdzQSA0hGGhfhQI X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208414 Archived-At: Nikolay Kudryavtsev writes: > Ok, would my original patch for it count as a safer way? It uses > internal tramp function, as discussed before, but the change itself is > local to vc-git. I don't decide whether such a patch shall be applied; it shall be decided by the vc maintainer. But in case of, the patch could be written shorter: --8<---------------cut here---------------start------------->8--- *** /usr/local/src/emacs-25/lisp/vc/vc-git.el.~12da149670a40c6d6c1bc107e8c29d7fcdcf7824~ 2016-10-18 14:29:18.559722705 +0200 --- /usr/local/src/emacs-25/lisp/vc/vc-git.el 2016-10-18 14:29:18.691725102 +0200 *************** *** 705,718 **** ;; arguments must be in the system codepage, and therefore ;; might not support the non-ASCII characters in the log ;; message. ! (if (eq system-type 'windows-nt) (make-temp-file "git-msg")))) (cl-flet ((boolean-arg-fn (argument) (lambda (value) (when (equal value "yes") (list argument))))) ;; When operating on the whole tree, better pass "-a" than ".", since "." ;; fails when we're committing a merge. (apply 'vc-git-command nil 0 (if only files) ! (nconc (if msg-file (list "commit" "-F" msg-file) (list "commit" "-m")) (let ((args (log-edit-extract-headers --- 705,727 ---- ;; arguments must be in the system codepage, and therefore ;; might not support the non-ASCII characters in the log ;; message. ! (if (eq system-type 'windows-nt) ! (if (file-remote-p file1) ! (with-parsed-tramp-file-name file1 nil ! (tramp-make-tramp-file-name ! method user host ! (tramp-make-tramp-temp-file v))) ! (make-temp-file "git-msg"))))) (cl-flet ((boolean-arg-fn (argument) (lambda (value) (when (equal value "yes") (list argument))))) ;; When operating on the whole tree, better pass "-a" than ".", since "." ;; fails when we're committing a merge. (apply 'vc-git-command nil 0 (if only files) ! (nconc (if msg-file ! (list ! "commit" "-F" ! (or (file-remote-p msg-file 'localname) msg-file)) (list "commit" "-m")) (let ((args (log-edit-extract-headers --8<---------------cut here---------------end--------------->8---