From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25123: 25.1.50; rx.el errs on character alternatives which include both ?\] and ?- Date: Wed, 07 Dec 2016 23:23:41 -0500 Message-ID: <877f7bf3qq.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1481170998 4084 195.159.176.226 (8 Dec 2016 04:23:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Dec 2016 04:23:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25123@debbugs.gnu.org To: Patrick Xarles Hayes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 08 05:23:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEqEg-00089Y-Cf for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Dec 2016 05:23:10 +0100 Original-Received: from localhost ([::1]:43994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEqEk-0003DU-Bn for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Dec 2016 23:23:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEqEd-0003Co-7U for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 23:23:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEqEY-0008Rb-6M for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 23:23:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45204) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cEqEY-0008RP-2l for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 23:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cEqEX-0006s3-Us for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2016 23:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2016 04:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25123 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25123-submit@debbugs.gnu.org id=B25123.148117097126380 (code B ref 25123); Thu, 08 Dec 2016 04:23:01 +0000 Original-Received: (at 25123) by debbugs.gnu.org; 8 Dec 2016 04:22:51 +0000 Original-Received: from localhost ([127.0.0.1]:60603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEqEN-0006rQ-20 for submit@debbugs.gnu.org; Wed, 07 Dec 2016 23:22:51 -0500 Original-Received: from mail-io0-f178.google.com ([209.85.223.178]:33075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEqEJ-0006r0-9Z; Wed, 07 Dec 2016 23:22:47 -0500 Original-Received: by mail-io0-f178.google.com with SMTP id j65so8528370iof.0; Wed, 07 Dec 2016 20:22:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5gRl5wHQEi/Dk0KVgrVNMfjYN5mkifCwTMvZyRS4up4=; b=ORozzCZcFcV9Dz5Va/XBke3xOqVSd8/fXiUzZd8lcE+xX/pYDrI8d78iZ/5c0a+/Gb qKZobYPnaHlH7Qg2WuddBLoJJlxaxq8SawHk762vY4ashUuAlR7WEWwdjwC+EPKIiw56 7Iy0GFE/naryjHFSgCA2+jd/sVEwCKWWguU3H/v4KH02HK5dg6lPVKB/jYdg3orQG4B2 CGhzBalOejuFVup9rZxhCtZ5K10bob8OvpPy2rPRW/epbGiOaY4hzqjTrg03kiHP2dfP 0wRUavTA3g97pcwlQRYsVTpoXSDs3PSqUBfu/1EkytDs+hHrNnUFm6y+i7uVD+dTWbCk usuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=5gRl5wHQEi/Dk0KVgrVNMfjYN5mkifCwTMvZyRS4up4=; b=OYDC0otVp+Bm+EUoZ1fMCP4aWsmOGVUcis8sQAAJgh9YqemKiNDu3G+yTjr0ZIPjSE MOTnCgUOfVqMzj7RbMpGbdgKuCqLUDAGsK8dTUvieEB9LuhQE6hQqqwbqUTEGvPDpX0c FpXtFGD5jpycweopvbUUOy4nI/KWLZejIiyUMTsur3TjpShGoqik5pL3MX8b40fYS1BA Pps0ZN/CrKzJ7Fw3yrjS7dkqAmNy1oMNzFhluWXGC/ozTT1D+KtVhUcNRcvYk2dabCK4 lSfQAPJmuVxf74iSC8d+HbOms6h20/fIM0RL0Mhng8PMawM3Mh2TK+aZKwzS+HtuN4w9 3qXQ== X-Gm-Message-State: AKaTC006pdLbgje7qi599HrKaACWuuIY71WTxPsaUAG6QDbXu10jREoBGr0Ztfb6kiisUQ== X-Received: by 10.36.85.151 with SMTP id e145mr166383itb.15.1481170961712; Wed, 07 Dec 2016 20:22:41 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id c36sm4664315itd.18.2016.12.07.20.22.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Dec 2016 20:22:40 -0800 (PST) In-Reply-To: (Patrick Xarles Hayes's message of "Tue, 6 Dec 2016 02:11:29 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126726 Archived-At: --=-=-= Content-Type: text/plain found 25123 24.3 tags 25123 patch quit Patrick Xarles Hayes writes: > The following fails in both Emacs 24.3.1 and 25.1.50.1: > > (require 'rx) > (rx-any '(char (93 . 123) (60 . 91) (45 . 58))) > > I rewrote `rx-any' to the following, and it seems to work (though it may > be introducing new bugs I'm not noticing): > There seems to be a lot of changes there, I can't really follow it. Here's a more minimal patch: --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=v1-0001-Fix-rx-any-with-range-with-and.patch Content-Description: patch >From ccb763c86dbb58972b49a26d5ffe5cf195a5975a Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 7 Dec 2016 23:17:37 -0500 Subject: [PATCH v1] Fix rx-any with range with ?\] and ?- * lisp/emacs-lisp/rx.el: Make sure not to produce a circular list. --- lisp/emacs-lisp/rx.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/rx.el b/lisp/emacs-lisp/rx.el index 66d295e..d305597 100644 --- a/lisp/emacs-lisp/rx.el +++ b/lisp/emacs-lisp/rx.el @@ -521,7 +521,7 @@ rx-any (setq args (nconc (delq ?- args) (list ?-)))) ((setq m (assq ?- args)) ;; next to the bracket's range, make the second range - (setcdr args (cons m (delq m args)))))) + (setcdr args (cons m (delq m (cdr args))))))) ;; bracket in the end range ;; => "[]...-]" ((setq m (rassq ?\] args)) -- 2.9.3 --=-=-=--