all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juliusz Chroboczek <jch@irif.fr>
To: emacs-devel@gnu.org
Subject: Re: Crashing the new thread code
Date: Sun, 11 Dec 2016 23:56:19 +0100	[thread overview]
Message-ID: <877f762hyk.fsf@irif.fr> (raw)
In-Reply-To: CAM-tV-92OC7kUGfBM4p=C0MvBuJiRPhVCzLUB47QeM09hMUNUg@mail.gmail.com

> I would expect the thread to receive the signal as soon as it starts
> running again.

I'm not sure what the semantics of signal-thread is supposed to be.  The
manual says:

    ‘thread-signal’ will cause a thread to exit a call to ‘mutex-lock’,
    ‘condition-wait’, or ‘thread-join’.

I assumed this to mean that the condition will only be delivered when
one of these functions is called, but your comment seems to imply that
it's meant to deliver the condition as soon as possible.

Which makes sense, but gives a whole new flavour to using unwind-protect
now that conditions can be signalled asynchronously.

(Aside: I'm actually not quite sure in that case that unwind-protect can
be used safely at all.  What happens if a condition is signalled during
the cleanup?  Say:

    (let ((foo nil))
      (unwind-protect
           (progn
             (setq foo (make-foo))
             (do-stuff-with foo))
        (when foo (destroy-foo foo))))

if a condition is signalled just before the cleanup but after exiting
the body, will we leak a foo?  End of aside.)

-- Juliusz




  reply	other threads:[~2016-12-11 22:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-11 18:37 Crashing the new thread code Juliusz Chroboczek
2016-12-11 20:34 ` Eli Zaretskii
2016-12-11 21:22   ` Juliusz Chroboczek
2016-12-11 21:58     ` Noam Postavsky
2016-12-11 22:56       ` Juliusz Chroboczek [this message]
2016-12-12  3:41       ` Eli Zaretskii
2016-12-12  4:10         ` Noam Postavsky
2016-12-12 17:11           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877f762hyk.fsf@irif.fr \
    --to=jch@irif.fr \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.