From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Tue, 20 Dec 2016 11:22:22 +0900 Message-ID: <877f6v2vc1.fsf@gmail.com> References: <874m2q1oca.fsf@gmail.com> <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> <87h96cr2su.fsf@secretsauce.net> <59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru> <9fe241fa-d4ee-6e44-bfdd-99cb6b4ab4e4@yandex.ru> <87fultr4he.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1482200596 7488 195.159.176.226 (20 Dec 2016 02:23:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Dec 2016 02:23:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Tino Calancha , Dmitry Gutov To: Dima Kogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 20 03:23:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJA57-0000TY-4R for ged-emacs-devel@m.gmane.org; Tue, 20 Dec 2016 03:23:09 +0100 Original-Received: from localhost ([::1]:48677 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJA5B-0003ui-9c for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2016 21:23:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJA4W-0003tU-8Q for emacs-devel@gnu.org; Mon, 19 Dec 2016 21:22:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJA4T-0008CS-5W for emacs-devel@gnu.org; Mon, 19 Dec 2016 21:22:32 -0500 Original-Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:35558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJA4S-0008CD-Vb for emacs-devel@gnu.org; Mon, 19 Dec 2016 21:22:29 -0500 Original-Received: by mail-pf0-x243.google.com with SMTP id i88so8099640pfk.2 for ; Mon, 19 Dec 2016 18:22:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=DBoQea+3zuEYhTn0DeRs2i04BdqKwAhM2UNaDvrpzcc=; b=gKNYl4ck22P3P+sdthIitgkZ/556ndhj4JBj/FtBZmnir6oU9L7beuy/8w9d2LfmuL USbGkS7jC6NmUwdZeUE/jPfEDTfhSF2GbMdPM/Sd7bgMkvbd14d3Hyt9ztzpjXVMW1CU s3bEptRU5Eo1iiDwVED4UOnqXKTGIq6acvuwGiwsWCcOqLA7zI8oSrFEI/ud4ANttQYr MKNtc1FNpz6OoDP9fhYo0JA6+A5ikOtTWnPuF6+7DRQX8g7VAmyakWj2zMaCUkSm7JeU cJpZHbXXNzMMFzPQQX4Q2h5SHj8XHeV/DXki/qd1z/3dCUvKz5te3lSgDkJHUNNFbbms 5aMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DBoQea+3zuEYhTn0DeRs2i04BdqKwAhM2UNaDvrpzcc=; b=uIcrDjzWMPEIoviNKkO/Ls9HApQ+gHs9Cgs+ciQaZorA1nvTnjXStrSfuG927nvFUy YEtciHb2qlZZby+jAmjKIMeVo7DCm90IG1qVX6Pnb/42kIumYHD/NjVpiZcDDxVuy3Id qugCtJhaRyZhytV5oEyP88DdbNOOtwW30yF7S68YzO8yymnLaJZ4+F8axJEQWvBc3Wkm XyOatsNjTkM2Qq/lkRYco0wubvQvOUd8lGGgJnFZTWyXIminRilOTTcR8eGmbqXk/SpB 2jwnTSFd24IsXkGYyUjShmP3C/YUJTOpdqTHlfKyBTGPU30wluapRB0tVWPtD6dXfN2u QeEg== X-Gm-Message-State: AKaTC0248CleKR4vsJGgNt06rILT5SiJ0ml/wdGk5Qr3LAHO13mqoH0zw+p9N6k/ZDSO3g== X-Received: by 10.99.251.69 with SMTP id w5mr32950652pgj.124.1482200548117; Mon, 19 Dec 2016 18:22:28 -0800 (PST) Original-Received: from calancha-pc (177.192.218.133.dy.bbexcite.jp. [133.218.192.177]) by smtp.gmail.com with ESMTPSA id q26sm34104414pfk.94.2016.12.19.18.22.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Dec 2016 18:22:27 -0800 (PST) In-Reply-To: <87fultr4he.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 11 Dec 2016 23:28:13 -0800") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210651 Archived-At: Dima Kogan writes: > Dmitry Gutov writes: > >> On 10.12.2016 19:27, Dima Kogan wrote: >> >>> For the other concerns, I can special-case the last hunk, and move to >>> eob for diff-next, and to ding only if we're already at eob to begin >>> with. > > Hi. I played around with this, and I now really don't like this idea > because it would mean that diff-hunk-next no longer always moves to the > next hunk. At the last hunk, diff-hunk-next would stay on the SAME hunk > if this was implemented. It would really make more sense if > > - diff-hunk-next moves to next hunk > - if this isn't possible, the point stays where it is, and an error is > signalled > > This is what the behavior in git intends to do. Hi Dima, after commit 2c8a7e5 the following receipt doesn't work: M-! git show HEAD RET C-x o C-x C-q M-x diff-mode RET n ;; Signal error: diff-beginning-of-file-and-junk: Can=E2=80=99t find the beginning of the fi= le I use above code very often: before commit 2c8a7e5, it skips the commit message and jumps to the first hunk. Is it possible to make above snippet working as before? Regards, Tino