all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Dima Kogan <dima@secretsauce.net>
Cc: emacs-devel@gnu.org, Tino Calancha <tino.calancha@gmail.com>,
	Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation
Date: Tue, 20 Dec 2016 11:22:22 +0900	[thread overview]
Message-ID: <877f6v2vc1.fsf@gmail.com> (raw)
In-Reply-To: <87fultr4he.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 11 Dec 2016 23:28:13 -0800")

Dima Kogan <dima@secretsauce.net> writes:

> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> On 10.12.2016 19:27, Dima Kogan wrote:
>>
>>> For the other concerns, I can special-case the last hunk, and move to
>>> eob for diff-next, and to ding only if we're already at eob to begin
>>> with.
>
> Hi. I played around with this, and I now really don't like this idea
> because it would mean that diff-hunk-next no longer always moves to the
> next hunk. At the last hunk, diff-hunk-next would stay on the SAME hunk
> if this was implemented. It would really make more sense if
>
> - diff-hunk-next moves to next hunk
> - if this isn't possible, the point stays where it is, and an error is
>   signalled
>
> This is what the behavior in git intends to do.
Hi Dima,
after commit 2c8a7e5 the following receipt doesn't work:

M-! git show HEAD RET
C-x o
C-x C-q
M-x diff-mode RET
n
;; Signal error:
diff-beginning-of-file-and-junk: Can’t find the beginning of the file

I use above code very often: before commit 2c8a7e5, it skips the commit
message and jumps to the first hunk.
Is it possible to make above snippet working as before?

Regards,
Tino



  parent reply	other threads:[~2016-12-20  2:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 12:07 [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Tino Calancha
2016-11-30  0:03 ` Noam Postavsky
2016-11-30 14:22 ` Dmitry Gutov
2016-11-30 14:31   ` Stefan Monnier
2016-11-30 14:34     ` Dmitry Gutov
2016-11-30 15:07       ` Stefan Monnier
2016-12-10  1:27   ` Dima Kogan
2016-12-10 10:14     ` Dmitry Gutov
2016-12-10 17:27       ` Dima Kogan
2016-12-11 11:07         ` Dmitry Gutov
2016-12-12  7:28           ` Dima Kogan
2016-12-16  1:05             ` Dmitry Gutov
2016-12-20  2:22             ` Tino Calancha [this message]
2016-12-20  7:31               ` Dima Kogan
2016-12-25  6:52               ` Dima Kogan
2016-12-25  9:48                 ` Tino Calancha
2016-12-25  9:58                   ` Tino Calancha
2016-12-25 14:10                     ` Dmitry Gutov
2016-12-06  2:03 ` Mark Oteiza
2016-12-07  7:29   ` Dima Kogan
2017-01-06  2:58     ` bug#25105: " Mark Oteiza
2017-01-06  2:58     ` Mark Oteiza
2016-12-07  7:29   ` bug#25105: " Dima Kogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877f6v2vc1.fsf@gmail.com \
    --to=tino.calancha@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=dima@secretsauce.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.