[PATCH] Fix gnus-thread-hide-subtree defcustom

[PATCH] Fix gnus-thread-hide-subtree defcustom

[Sergey Organov]

* lisp/gnus/gnus-sum.el (gnus-thread-hide-subtree): fix order of
items, to prevent first 'sexp' from matching 'nil.
---
 lisp/gnus/gnus-sum.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index b6023c2..b4c61ed 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -290,11 +290,11 @@ This can be a predicate specifier which says which threads to hide.
 If threads are hidden, you have to run the command
 `gnus-summary-show-thread' by hand or select an article."
   :group 'gnus-thread
-  :type '(radio (sexp :format "Non-nil\n"
+  :type '(radio (const nil)
+		(sexp :format "Non-nil\n"
 		      :match (lambda (widget value)
 			       (not (or (consp value) (functionp value))))
 		      :value t)
-		(const nil)
 		(sexp :tag "Predicate specifier")))
 
 (defcustom gnus-thread-hide-killed t
-- 
2.1.4

Re: [PATCH] Fix gnus-thread-hide-subtree defcustom

[Ted Zlatanov]

On Wed, 28 Dec 2016 16:09:28 +0300 Sergey Organov <sorganov@gmail.com> wrote: 

SO> * lisp/gnus/gnus-sum.el (gnus-thread-hide-subtree): fix order of
SO> items, to prevent first 'sexp' from matching 'nil.

That looks good and it's a tiny change. One minor issue: are you the
"Sergei Organov <osv@javad.com>" that has an earlier tiny change from
2011? If so, I'm not sure if I need to add that to admin/authors.el
(since both changes are tiny).

Thanks
Ted

Re: [PATCH] Fix gnus-thread-hide-subtree defcustom

[Sergey Organov]

Ted Zlatanov <tzz@lifelogs.com> writes:
> On Wed, 28 Dec 2016 16:09:28 +0300 Sergey Organov <sorganov@gmail.com> wrote: 
>
> SO> * lisp/gnus/gnus-sum.el (gnus-thread-hide-subtree): fix order of
> SO> items, to prevent first 'sexp' from matching 'nil.
>
> That looks good and it's a tiny change. One minor issue: are you the
> "Sergei Organov <osv@javad.com>" that has an earlier tiny change from
> 2011? If so, I'm not sure if I need to add that to admin/authors.el
> (since both changes are tiny).

Yeah, the same person, and I'm not insisting on adding me anywhere.

-- Sergey.