From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23007: 24.5; buggy interactive search with middle click Date: Tue, 30 May 2017 07:47:56 -0400 Message-ID: <877f0y4lcj.fsf@users.sourceforge.net> References: <87a8m13gba.fsf@zira.vinc17.org> <871sr7h1xy.fsf@gmail.com> <87inkj43q9.fsf@users.sourceforge.net> <8760gjqcwh.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496144833 2452 195.159.176.226 (30 May 2017 11:47:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 11:47:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Vincent Lefevre , 23007@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 30 13:47:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFfc9-0000Lv-8f for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 May 2017 13:47:05 +0200 Original-Received: from localhost ([::1]:53034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFfcE-0006sD-KG for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 May 2017 07:47:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFfc9-0006s8-NQ for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 07:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFfc6-0003Oc-HG for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 07:47:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFfc6-0003OX-DY for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 07:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFfc6-0008Ps-0w for bug-gnu-emacs@gnu.org; Tue, 30 May 2017 07:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2017 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23007-submit@debbugs.gnu.org id=B23007.149614478732311 (code B ref 23007); Tue, 30 May 2017 11:47:01 +0000 Original-Received: (at 23007) by debbugs.gnu.org; 30 May 2017 11:46:27 +0000 Original-Received: from localhost ([127.0.0.1]:44218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFfbW-0008P5-NU for submit@debbugs.gnu.org; Tue, 30 May 2017 07:46:27 -0400 Original-Received: from mail-it0-f66.google.com ([209.85.214.66]:33570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFfbV-0008Os-6N for 23007@debbugs.gnu.org; Tue, 30 May 2017 07:46:25 -0400 Original-Received: by mail-it0-f66.google.com with SMTP id l145so9325839ita.0 for <23007@debbugs.gnu.org>; Tue, 30 May 2017 04:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vEExmXhEmZHtXuNJi+1Xro68r2rQ9b2xIBvKnoC0vMs=; b=Wvd28WyKNeQELN678w+P6tMNnFKODt7P3yGEnvPtYWPRiUPqlXqV/M1BerfjtcaDIv cDEcu30rb/iKM4ROqDjGPA37U/mLe0vckQMF7nVlrpiP2Q4tnt618afrs2heMKO9Sesn 7LER2vXyrydf/DuKJTIFSUyPmDRf08lQw+OpiL5Rf/fkN1UmlYF2V0mhVFcKcMhYm+xv 0BIjj4hVPh47BlC17pbiK6Qt6eLt38exdaeL5NZZgwzfxsukLkBU9KUD0rrEQn0AjyQj Dy+2EAhHv96T52G3XrHMK/Z/9im/wTI9RIGi/cev0gPQgSG/5c5bRNRXwzG7XZnvo/gc 5z/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=vEExmXhEmZHtXuNJi+1Xro68r2rQ9b2xIBvKnoC0vMs=; b=cw0apm8UaGpXWQ/QC9Cso7NG68dI+E6jAPd1pOIcDHNKArgbjkpo40I4+rbtPy/7Ik F6PQhvTYdjKduFzjqq7RW55QA9WSwHyQWAlt9taYpOH7aUEqwmBJKROPmoHMHxC4NnLP XZy10Cm3YDTM/Et/iqDAxFr9CSqzmyMZQ0BPi8ZzH5m49UIWv01//vwfG0lu38WBTZLd Db4ria+jbRGW6sw6lvda0M3DtedEqwDV8izchImkPWnQJJim7fQ2YTWnL0FylauSH9VB oc/M4DHAWIzJlg3rxMaNOPuxnc5CUbolE7A21jmKvEoDEzKOF2OUBLToVM1hpIRHhHcQ IObQ== X-Gm-Message-State: AODbwcA1L24xOWA3G3uO8yJHSs3/JAINFIhkDw7DRBUnN74dTSYTpdVT bNli8XyMOKiFRw== X-Received: by 10.36.13.14 with SMTP id 14mr1407648itx.105.1496144779533; Tue, 30 May 2017 04:46:19 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e21sm5448010ioj.15.2017.05.30.04.46.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 May 2017 04:46:18 -0700 (PDT) In-Reply-To: <8760gjqcwh.fsf@gmail.com> (Alex's message of "Mon, 29 May 2017 20:47:10 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133049 Archived-At: Alex writes: > npostavs@users.sourceforge.net writes: > >> Alex writes: >> >>> + (let ((overriding-terminal-local-map nil)) >>> + (setq binding (key-binding (this-command-keys-vector) t))) >> >> IMO, it would be better style to do something like >> >> (let ((binding (let ((overriding-terminal-local-map nil)) >> (key-binding (this-command-keys-vector) t)))) >> ...) > > That was my first idea, but at the time I thought it was better style to > use the setq version instead. :) Hah, well it is somewhat a question of personal opinion, but generally I try to avoid setq, if it's not too much trouble. > Your version makes the binding more obvious, though, so I updated the > patch to use it. I've attached it below. Ok, I'll push to master in a couple of days.