From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dieter Deyke Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] elpa/packages/sokoban/sokoban.el Date: Sun, 09 Jul 2017 16:34:05 +0200 Message-ID: <877ezhllwi.fsf@deyke2> References: <87bmotlokk.fsf@deyke2> <83o9stk87j.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499611852 13611 195.159.176.226 (9 Jul 2017 14:50:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Jul 2017 14:50:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 09 16:50:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUDXp-0003Ap-4n for ged-emacs-devel@m.gmane.org; Sun, 09 Jul 2017 16:50:45 +0200 Original-Received: from localhost ([::1]:36401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUDXu-0006Jw-MN for ged-emacs-devel@m.gmane.org; Sun, 09 Jul 2017 10:50:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUDJG-0004FQ-Ft for emacs-devel@gnu.org; Sun, 09 Jul 2017 10:35:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUDJB-0008Lh-JT for emacs-devel@gnu.org; Sun, 09 Jul 2017 10:35:42 -0400 Original-Received: from mail-wr0-f180.google.com ([209.85.128.180]:35655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUDJA-00087K-Lz; Sun, 09 Jul 2017 10:35:37 -0400 Original-Received: by mail-wr0-f180.google.com with SMTP id k67so105788257wrc.2; Sun, 09 Jul 2017 07:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=t6VfonDxALjEs9ayiozgvJNuOWk0I4IVYlnhhhEUMvA=; b=hqLMQ6uqcwjFrkN2xJB0zO+8wkLJNormxcDIu5TnQwWraQ+1+2ZSwmynTWYXFz/VHO Gvti018yG3uK12kQRYtLdOTO7Se92Yv3iCCzbXUq2Mx9lVzklmzQ/2gJ5H4G/EDx8QOu GxVQBCq3o4bm0j4tE9erHCUc+wJ0XtIs2G9rIRaGWHEfNp89lRyD04ScINZ78GbxjK7C A+WrYky5ltIlDnUVlV85wyDl5PT18Csk4XfjqyvHXzXv0e5gZaVuDwAusC3jY7IWzB/D i70tA46I7SAc9ETnRm4NMK4doo/Uxs0uYXbh/yqUhcGz2VxhALS+YIBhX//CvxBOks6A ABJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=t6VfonDxALjEs9ayiozgvJNuOWk0I4IVYlnhhhEUMvA=; b=PAmNA9rW6vxQcStUFv9bZYlX7K6AgR5pqVIUc8ScJh8o+/MdwQ1FbaWD0mSqFrpg6m VyS9DxIFiGA0f0ZyqdEaE/6QCp0WZiERKFMYzi7N+ScXBSsXcQjZ5kS5Atp3PPtBZgMp bqveMlQxh6ljf2KyUSD1TfGaS1507blyVKKLCTeZG51fI1ou0+3LaP3YYSSJ/10O6zRR OZhiLuDBeIW4lSIZZ9IyCdNgMgRU85Ya7fxqOEx42CqjyUE4u4XmBSNFP2r8b775FwWo Et3ykfMiE5uPHrP4mkPMtOdvtXc7ppzNkKRjx7dk+dhZ4o/TtPVPa6SE436u43Zpn6s9 8ltw== X-Gm-Message-State: AIVw112rgM2C4Kgqw+n2ST8pLZnLH6d7KecufrMIpB4pLzz/Sr4Ox7y7 yOLb6mRvnbMVeJPA X-Received: by 10.28.107.131 with SMTP id a3mr5062767wmi.60.1499610852592; Sun, 09 Jul 2017 07:34:12 -0700 (PDT) Original-Received: from deyke2.fritz.box (p5B12C03C.dip0.t-ipconnect.de. [91.18.192.60]) by smtp.gmail.com with ESMTPSA id w96sm7485854wrc.33.2017.07.09.07.34.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Jul 2017 07:34:11 -0700 (PDT) Original-Received: from [127.0.0.1] (helo=deyke2.localdomain) by deyke2 with esmtp (Exim 4.89) (envelope-from ) id 1dUDHh-00081t-Mg; Sun, 09 Jul 2017 16:34:05 +0200 In-Reply-To: <83o9stk87j.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jul 2017 17:15:12 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.180 X-Mailman-Approved-At: Sun, 09 Jul 2017 10:50:46 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216368 Archived-At: Eli Zaretskii writes: >> From: Dieter Deyke >> Date: Sun, 09 Jul 2017 15:36:27 +0200 >> >> I would like to patch elpa/packages/sokoban/sokoban.el to change the >> player and block color if on a target field. This makes it much easier >> to see if a block is already correctly placed or not. >> >> Comments? > > Please show the commit log message you intend to use. > > Also, does this warrant a NEWS entry? > > Thanks. The commit log message I was about to use is change player and block color if on target About a NEWS entry, I do not know. Does ELPA have a separate NEWS file? I see some NEWS files in some individual packages, but sokoban did not have one so far. I made an entry in the header of sokoban.el under Commentary: , is this enough? Thanks for looking at the patch! -- Dieter Deyke mailto:dieter.deyke@gmail.com Get my Gnupg key: gpg --keyserver keys.gnupg.net --recv-keys B116EA20