all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dieter Deyke <dieter.deyke@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] elpa/packages/sokoban/sokoban.el
Date: Sun, 09 Jul 2017 16:34:05 +0200	[thread overview]
Message-ID: <877ezhllwi.fsf@deyke2> (raw)
In-Reply-To: <83o9stk87j.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jul 2017 17:15:12 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Dieter Deyke <dieter.deyke@gmail.com>
>> Date: Sun, 09 Jul 2017 15:36:27 +0200
>>
>> I would like to patch elpa/packages/sokoban/sokoban.el to change the
>> player and block color if on a target field. This makes it much easier
>> to see if a block is already correctly placed or not.
>>
>> Comments?
>
> Please show the commit log message you intend to use.
>
> Also, does this warrant a NEWS entry?
>
> Thanks.

The commit log message I was about to use is

change player and block color if on target

About a NEWS entry, I do not know. Does ELPA have a separate NEWS file?
I see some NEWS files in some individual packages, but sokoban did not
have one so far. I made an entry in the header of sokoban.el under
Commentary: , is this enough?

Thanks for looking at the patch!
-- 
Dieter Deyke
mailto:dieter.deyke@gmail.com
Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20



  reply	other threads:[~2017-07-09 14:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09 13:36 [PATCH] elpa/packages/sokoban/sokoban.el Dieter Deyke
2017-07-09 14:15 ` Eli Zaretskii
2017-07-09 14:34   ` Dieter Deyke [this message]
2017-07-09 14:52     ` Eli Zaretskii
2017-07-11 15:17       ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2017-07-16 14:14 Dieter Deyke
2017-07-16 16:01 ` Stefan Monnier
2017-07-16 16:57   ` Dieter Deyke
2017-07-25 11:36 Dieter Deyke
2017-07-25 14:24 ` Stefan Monnier
2019-02-07 10:51 Dieter Deyke
2019-02-07 12:53 ` Clément Pit-Claudel
2019-02-07 14:42   ` Eli Zaretskii
2019-02-07 15:57     ` Dieter Deyke
2019-02-07 16:08       ` Clément Pit-Claudel
2019-02-07 16:11         ` Dieter Deyke
2019-02-07 16:55       ` Andreas Schwab
2019-02-08  3:34         ` Stefan Monnier
2019-02-07 14:56 ` Stefan Monnier
2019-02-12 12:30 Dieter Deyke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ezhllwi.fsf@deyke2 \
    --to=dieter.deyke@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.