%K template escape doesn't link to exact task headline

%K template escape doesn't link to exact task headline

[Michal Politowski]

Hello everyone and thank you for the fascinating org mode,

Is the behaviour of %K a bug in the documentation, in the implementation,
or just my unfounded expectation?

It is supposed to link "to the currently clocked task" but it is implemented
in org-capture.el as

(v-K (if (marker-buffer org-clock-marker)
		  (org-make-link-string
		   (buffer-file-name (marker-buffer org-clock-marker))
		   org-clock-heading)))

<http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el#n1611>

which only puts the headline text in the link description,
the actual link is just to the task file - not what I would expect.

-- 
Michał Politowski

Re: %K template escape doesn't link to exact task headline

[Nicolas Goaziou]

Hello,

Michal Politowski <mpol@meep.pl> writes:

> Hello everyone and thank you for the fascinating org mode,
>
> Is the behaviour of %K a bug in the documentation, in the implementation,
> or just my unfounded expectation?
>
> It is supposed to link "to the currently clocked task" but it is implemented
> in org-capture.el as
>
> (v-K (if (marker-buffer org-clock-marker)
> 		  (org-make-link-string
> 		   (buffer-file-name (marker-buffer org-clock-marker))
> 		   org-clock-heading)))
>
> <http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el#n1611>
>
> which only puts the headline text in the link description,
> the actual link is just to the task file - not what I would expect.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: %K template escape doesn't link to exact task headline

[Michal Politowski]

On Thu, 13 Jul 2017 14:27:11 +0200, Nicolas Goaziou wrote:
> Hello,
> 
> Michal Politowski <mpol@meep.pl> writes:
> 
> > Hello everyone and thank you for the fascinating org mode,
> >
> > Is the behaviour of %K a bug in the documentation, in the implementation,
> > or just my unfounded expectation?
> >
> > It is supposed to link "to the currently clocked task" but it is implemented
> > in org-capture.el as
> >
> > (v-K (if (marker-buffer org-clock-marker)
> > 		  (org-make-link-string
> > 		   (buffer-file-name (marker-buffer org-clock-marker))
> > 		   org-clock-heading)))
> >
> > <http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el#n1611>
> >
> > which only puts the headline text in the link description,
> > the actual link is just to the task file - not what I would expect.
> 
> Fixed. Thank you.

Thank you. Wouldn't it be better to still have a link description though?
Probably both versions have advantages.

diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 44dbb7f96..7b880cf9a 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -1613,7 +1613,8 @@ The template may still contain \"%?\" for cursor positioning."
                  (org-make-link-string
                   (format "%s::%s"
                           (buffer-file-name (marker-buffer org-clock-marker))
-                          (org-no-properties org-clock-heading)))
+                          (org-no-properties org-clock-heading))
+                  (org-no-properties org-clock-heading))
                ""))
         (v-f (or (org-capture-get :original-file-nondirectory) ""))
         (v-F (or (org-capture-get :original-file) ""))


-- 
Michał Politowski

Re: %K template escape doesn't link to exact task headline

[Nicolas Goaziou]

Hello,

Michal Politowski <mpol@meep.pl> writes:

> Thank you. Wouldn't it be better to still have a link description
> though?

Done. Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738