From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: find-dups Date: Wed, 11 Oct 2017 21:25:36 +0200 Message-ID: <877ew1ebbj.fsf@web.de> References: <87fuapemew.fsf@web.de> <87bmldefg5.fsf@web.de> <83fuapo6ms.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507749993 1311 195.159.176.226 (11 Oct 2017 19:26:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Oct 2017 19:26:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: rswgnu@gmail.com, emacs-devel@gnu.org, rsw@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 11 21:26:29 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2Me7-0007Sq-WB for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 21:26:24 +0200 Original-Received: from localhost ([::1]:42364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2MeB-0002xs-Qe for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 15:26:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2MdY-0002xh-N6 for emacs-devel@gnu.org; Wed, 11 Oct 2017 15:25:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2MdX-00038G-Rx for emacs-devel@gnu.org; Wed, 11 Oct 2017 15:25:48 -0400 Original-Received: from mout.web.de ([212.227.15.3]:53688) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2MdQ-00030l-TH; Wed, 11 Oct 2017 15:25:41 -0400 Original-Received: from drachen.dragon ([88.67.74.137]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Mb6EN-1diEYL1QvT-00KeN3; Wed, 11 Oct 2017 21:25:38 +0200 In-Reply-To: <83fuapo6ms.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Oct 2017 21:56:43 +0300") X-Provags-ID: V03:K0:X+/FXVtVIoDQllsjHj1NeXXgmswsuvihl6ujRS/g8+hr9RHtj8b G6mlnxC/uNCKZT/H/5w3VeRudSJz4zASjGGeOgM7WUJ9MdtEoTPG5aaYo/oWVVF+qCgViww XzufE3ctuF/5tPo1JwTKyG1JmJQe9zQJQAjSTIvGP1QQK7w6XYhMG7NR0NYEiEtHo+d6KYy mnQbtsioBPmyi0kUbZKNQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:pMw8OS+aXoM=:qkrqvi1fmqt3pXoUNgF6rr X8sZxGrhxhpRDQt/xu+JXg5fGncEyVXrh2Fth/sh3LX+2So1S/SCIq2GgqKGH1q3iRKQmggAp CFeywDIBO7eMwvsaL1AXUUpyMtllnVXjZhPYywWu7h6SIGMHxYP4QJeF2Nq2mkfO1AMEZXLej k1AZXMjln7UNvLOczlW4qpUEJyDYc1bSfrOyjUThO5uLyWtqjcIrJ5655j1tjHG/aDjVXbJ1o qgnbcfrOQfWDpMvf1Gq1hOokQIAVZ6ed/F03Is7NmjkAt7h+Fse/OWd7cmMmtpCzVjahayXj/ oqOQKvKbFVV+tcMVcDSILTUMZ+Vj/7v0QnqsvMdRSqZ0tJpAwT4arkzZ/WKfujawrgY7Hp0zk vLVuryixksp34zxdPFEoua+F/sBC0AlniRH958bT1TlpnEFJsEnshNES7oHso3HzuY07MKGk3 MkkopD1yXxSbe5TJ/4gIedoGR4TR41DglrQw8gZHiGxLv2lZn5yKUkAkTMYrQV2SCd4/YGU6F 83Hsgaw+AwphTR5phDq2fT+T4Hx5UB0LkkiSS/3JYeQreQUlVMk1SIDy7fVWW575zVO+6b1wH haY3JUMbkrsFLtmnyPFGFIf0r/ZgzZ8d0NA3hFy6rI0xdmPOpzQnoA8HZESZXQKOBaett7CT3 XUQ5bxVH/u4E1USUQnNH2jEcxMgf9zsI8bEuO3wPEYgo9n2hnKQ1h94bx+YoN/nstG3n7dqAu 5D4zhbEH02ObLvlEYJvg+NtTN4gN2JJoftry2bIJIQzpJ75YyJ1MLgyPg7DTGtdgPCPOarAc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219387 Archived-At: Hi Eli, Thanks for your comment. > Apologies for barging into the middle of a discussion, but starting > processes and making strings out of their output to process just a > portion of a file is sub-optimal, because process creation is not > cheap. It is easier to simply read a predefined number of bytes into > a buffer; insert-file-contents-literally supports that. Likewise with > md5sum: we have the md5 primitive for that. That's one of the details I delayed until I know whether we want this for inclusion. My first version used `insert-file-contents-literally' but I ran into problems, and calling `debug' crashed Emacs, so I gave up for the moment. Personally, I don't care that much because it doesn't make a big speed difference, but yes, I know it's not absolutely correct, and I would care about this. Regards, Michael.