* bug#28831: 27.0.50; debbugs: funny address in To field
@ 2017-10-14 9:45 Tino Calancha
2017-10-20 0:29 ` Noam Postavsky
0 siblings, 1 reply; 7+ messages in thread
From: Tino Calancha @ 2017-10-14 9:45 UTC (permalink / raw)
To: 28831; +Cc: larsi
X-Debbugs-CC: michael.albinus@gmx.de
X-Debbugs-CC: larsi@gnus.org
Recently when using debbugs to list the bug reports,
I see a new address in the 'To' as 'xxxxx@https:'
with xxxxx the bug number. For instance, this is the
headers from Bug#24000:
From: "Greg A. Woods" <woods@robohack.ca>
Subject: bug#24000: 24.5; makefile-bsdmake-mode has incomplete keyword syntax
To: 24000@debbugs.gnu.org, 24000@https:
Date: Fri, 15 Jul 2016 15:28:43 -0700 (1 year, 12 weeks, 6 days ago)
Resent-From: "Greg A. Woods" <woods@robohack.ca>
Reply-To: "Greg A. Woods" <woods@robohack.ca>
When I reply such reports the funny address appear in CC.
What are those '24000@https:'? Do we need them?
In GNU Emacs 27.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
of 2017-10-14
Repository revision: dcb86584fd12fc44d246bbe033372693785c127d
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28831: 27.0.50; debbugs: funny address in To field
2017-10-14 9:45 bug#28831: 27.0.50; debbugs: funny address in To field Tino Calancha
@ 2017-10-20 0:29 ` Noam Postavsky
2017-10-20 2:14 ` Tino Calancha
2017-10-20 9:35 ` Lars Ingebrigtsen
0 siblings, 2 replies; 7+ messages in thread
From: Noam Postavsky @ 2017-10-20 0:29 UTC (permalink / raw)
To: Tino Calancha; +Cc: 28831, larsi
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
tags 28831 + patch
quit
Tino Calancha <tino.calancha@gmail.com> writes:
> When I reply such reports the funny address appear in CC.
> What are those '24000@https:'? Do we need them?
Hah, I thought I was the only one (somehow this report did not land in
my inbox, I only happened to find it when looking at the bug list). The
following seems to fix it, but there is some caching. When I open this
bug the "https:" is still there, but opening other bugs that I haven't
opened in the current session yet then it's not. I'm not sure where the
cache is kept.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1136 bytes --]
From e1c49aec252ac8e79631c96fe68d2dcc725bdde4 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Thu, 19 Oct 2017 20:07:05 -0400
Subject: [PATCH] Handle https url for debbugs mbox (Bug#28831)
In 2017-09-13 "Prefer HTTPS to FTP and HTTP in documentation",
gnus-bug-group-download-format-alist was updated to use https for the
debbugs.gnu.org mbox links, but gnus-read-ephemeral-bug-group assumed
http links.
* lisp/gnus/gnus-group.el (gnus-read-ephemeral-bug-group): Strip
https, not http.
---
lisp/gnus/gnus-group.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 985efe6272..259d046e9e 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -2469,7 +2469,7 @@ gnus-read-ephemeral-bug-group
(format "%s@%s" (car ids)
(replace-regexp-in-string
"/.*$" ""
- (replace-regexp-in-string "^http://" "" mbox-url)))))
+ (replace-regexp-in-string "^https://" "" mbox-url)))))
(goto-char (point-min))
(while (re-search-forward (concat "^" message-unix-mail-delimiter)
nil t)
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#28831: 27.0.50; debbugs: funny address in To field
2017-10-20 0:29 ` Noam Postavsky
@ 2017-10-20 2:14 ` Tino Calancha
2017-10-20 9:35 ` Lars Ingebrigtsen
1 sibling, 0 replies; 7+ messages in thread
From: Tino Calancha @ 2017-10-20 2:14 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 28831, larsi
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> tags 28831 + patch
> quit
>
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> When I reply such reports the funny address appear in CC.
>> What are those '24000@https:'? Do we need them?
>
> The following seems to fix it, but there is some caching. When I open this
> bug the "https:" is still there, but opening other bugs that I haven't
> opened in the current session yet then it's not. I'm not sure where the
> cache is kept.
Excellent! It works here.
Thank you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28831: 27.0.50; debbugs: funny address in To field
2017-10-20 0:29 ` Noam Postavsky
2017-10-20 2:14 ` Tino Calancha
@ 2017-10-20 9:35 ` Lars Ingebrigtsen
2017-10-20 12:55 ` Noam Postavsky
1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2017-10-20 9:35 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 28831, Tino Calancha
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> - (replace-regexp-in-string "^http://" "" mbox-url)))))
> + (replace-regexp-in-string "^https://" "" mbox-url)))))
Perhaps that should be
> + (replace-regexp-in-string "^https?://" "" mbox-url)))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28831: 27.0.50; debbugs: funny address in To field
2017-10-20 9:35 ` Lars Ingebrigtsen
@ 2017-10-20 12:55 ` Noam Postavsky
2017-10-20 13:53 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: Noam Postavsky @ 2017-10-20 12:55 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 28831, Tino Calancha
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Noam Postavsky <npostavs@users.sourceforge.net> writes:
>
>> - (replace-regexp-in-string "^http://" "" mbox-url)))))
>> + (replace-regexp-in-string "^https://" "" mbox-url)))))
>
> Perhaps that should be
>
>> + (replace-regexp-in-string "^https?://" "" mbox-url)))))
Or maybe we could use url-parse? Seems a bit neater.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1292 bytes --]
From 992b5b8a33eab5ea0afa020030408f76dcfd4330 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Thu, 19 Oct 2017 20:07:05 -0400
Subject: [PATCH v2] Handle https url for debbugs mbox (Bug#28831)
In 2017-09-13 "Prefer HTTPS to FTP and HTTP in documentation",
gnus-bug-group-download-format-alist was updated to use https for the
debbugs.gnu.org mbox links, but gnus-read-ephemeral-bug-group assumed
http links.
* lisp/gnus/gnus-group.el (gnus-read-ephemeral-bug-group): Use
url-parse functions to get the host name, instead of ad-hoc regexps.
---
lisp/gnus/gnus-group.el | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 985efe6272..4a41c49590 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -2467,9 +2467,7 @@ gnus-read-ephemeral-bug-group
;; Add the debbugs address so that we can respond to reports easily.
(let ((address
(format "%s@%s" (car ids)
- (replace-regexp-in-string
- "/.*$" ""
- (replace-regexp-in-string "^http://" "" mbox-url)))))
+ (url-host (url-generic-parse-url mbox-url)))))
(goto-char (point-min))
(while (re-search-forward (concat "^" message-unix-mail-delimiter)
nil t)
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#28831: 27.0.50; debbugs: funny address in To field
2017-10-20 12:55 ` Noam Postavsky
@ 2017-10-20 13:53 ` Lars Ingebrigtsen
2017-10-21 19:52 ` Noam Postavsky
0 siblings, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2017-10-20 13:53 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 28831, Tino Calancha
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Or maybe we could use url-parse? Seems a bit neater.
Yeah, sounds good.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28831: 27.0.50; debbugs: funny address in To field
2017-10-20 13:53 ` Lars Ingebrigtsen
@ 2017-10-21 19:52 ` Noam Postavsky
0 siblings, 0 replies; 7+ messages in thread
From: Noam Postavsky @ 2017-10-21 19:52 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 28831, Tino Calancha
tags 28831 fixed
close 28831 26.1
quit
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Noam Postavsky <npostavs@users.sourceforge.net> writes:
>
>> Or maybe we could use url-parse? Seems a bit neater.
>
> Yeah, sounds good.
Pushed to emacs-26.
[1: b060e091c3]: 2017-10-21 15:19:14 -0400
Handle https url for debbugs mbox (Bug#28831)
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b060e091c35e8482e0e091a214cf5afe5039bd0e>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-10-21 19:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-14 9:45 bug#28831: 27.0.50; debbugs: funny address in To field Tino Calancha
2017-10-20 0:29 ` Noam Postavsky
2017-10-20 2:14 ` Tino Calancha
2017-10-20 9:35 ` Lars Ingebrigtsen
2017-10-20 12:55 ` Noam Postavsky
2017-10-20 13:53 ` Lars Ingebrigtsen
2017-10-21 19:52 ` Noam Postavsky
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.