From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Something weird with when-let*/if-let* Date: Sat, 14 Oct 2017 14:10:38 +0200 Message-ID: <877evy2am9.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507983209 2340 195.159.176.226 (14 Oct 2017 12:13:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 12:13:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 14 14:13:19 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3LJL-0005PM-LC for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2017 14:12:59 +0200 Original-Received: from localhost ([::1]:53896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3LJS-0001Fd-VM for ged-emacs-devel@m.gmane.org; Sat, 14 Oct 2017 08:13:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3LIt-0001FW-3A for emacs-devel@gnu.org; Sat, 14 Oct 2017 08:12:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3LIq-0001yW-Dd for emacs-devel@gnu.org; Sat, 14 Oct 2017 08:12:31 -0400 Original-Received: from [195.159.176.226] (port=40997 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3LIq-0001xp-6d for emacs-devel@gnu.org; Sat, 14 Oct 2017 08:12:28 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e3LIX-0007VL-Ce for emacs-devel@gnu.org; Sat, 14 Oct 2017 14:12:09 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:QBIapb/g9qn2U009l1z5q+CQKd4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219510 Archived-At: I've seen this in two different contexts now: using the starred versions of when-let or if-let results in a `invalid-function' error on the first let-binding, as if something is trying to treat the whole binding form as a function. I got one report on EBDB about this function: (cl-defmethod ebdb-record-uuid ((record ebdb-record)) (if-let* ((uuid-field (slot-value record 'uuid))) (slot-value uuid-field 'uuid))) Where the error was: "(invalid-function (uuid-field (slot-value record (quote uuid))))" (https://github.com/girzel/ebdb/issues/54#issuecomment-335033393) And Julien Cubizolles just reported to the Gnus list that this code chunk from nnimap.el: (when-let* ((result (eval accept-form))) (nnimap-change-group group server) (nnimap-delete-article article) result) Was producing a similar error: "Invalid function: (result (eval accept-form))" Switching to the un-starred version fixed the problem. I tried this out on the emacs-26 and master branches, and I can't raise the error. Julien's on master, with the EBDB reporter it was unclear. The macroexpansion looks fine, of course. I guess I should just make a bug report... Eric