From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jay Kamat Newsgroups: gmane.emacs.bugs Subject: bug#29111: 26.0.90; Erc keep-place module broken with new default of switch-to-buffer-preserve-window-point Date: Fri, 03 Nov 2017 01:54:29 -0400 Message-ID: <877ev7zz3e.fsf@gmail.com> References: <87inetcppp.fsf@gmail.com> <59FAEA9C.1050608@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1509688509 13243 195.159.176.226 (3 Nov 2017 05:55:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2017 05:55:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29111@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 03 06:55:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAUwa-00030K-PB for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 06:55:05 +0100 Original-Received: from localhost ([::1]:35014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAUwh-00048l-ND for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Nov 2017 01:55:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAUwc-00048a-7b for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 01:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAUwZ-0002Nw-5F for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 01:55:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAUwY-0002Nc-Vz for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 01:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eAUwY-0001DI-JB for bug-gnu-emacs@gnu.org; Fri, 03 Nov 2017 01:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jay Kamat Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Nov 2017 05:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29111 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29111-submit@debbugs.gnu.org id=B29111.15096884794631 (code B ref 29111); Fri, 03 Nov 2017 05:55:02 +0000 Original-Received: (at 29111) by debbugs.gnu.org; 3 Nov 2017 05:54:39 +0000 Original-Received: from localhost ([127.0.0.1]:48565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAUwB-0001Cc-4z for submit@debbugs.gnu.org; Fri, 03 Nov 2017 01:54:39 -0400 Original-Received: from mail-yw0-f182.google.com ([209.85.161.182]:48349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAUw9-0001CP-3T for 29111@debbugs.gnu.org; Fri, 03 Nov 2017 01:54:37 -0400 Original-Received: by mail-yw0-f182.google.com with SMTP id q1so1554026ywh.5 for <29111@debbugs.gnu.org>; Thu, 02 Nov 2017 22:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=vhDbsEkWNAtLKZQqm4WzPQxYUK7JrhUmhxerR9GOwXI=; b=Pw6l+MrL4HRJLle2W4isBXp0YaqY1CDkf4naq/f4WBYiHyFYC7boSYfp+Hbl5ZyImV QLRMu6g6sTTFDifFyPdp3wRHx5w+vtuR1qeM+M/0FKgki099t3838HJYose4+rm+D7A4 alWyT0bCKTD55DS4WeczCLYURGZkujJC4lNTGTNB4zY9yzW0PWocKFASczzPW9zD6BND WclSe8HTG7xCj+g9Yn2ICw/Gv6SdlswwZQbMk9aaPaQC7UWybr/mIieZCjfJ6O/Oq7sy YGnRSunvJpDEiYugnpDrs/IJmRdP5afb1i8dBTkSwFhbFn3xy/lAi1BsKYKNklx+G1KU puwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=vhDbsEkWNAtLKZQqm4WzPQxYUK7JrhUmhxerR9GOwXI=; b=AUmMgxHdpmhGLT7taeKM5tyGVqKgNxvkUWe5Lp3zCwHqV8+CCpjUGV6UQnCcqnVrwL rkb6QF8ib4s/F1ikEouWF75iLjSnMVEGPiAx3SJbmQmwnqPOl2De3LFIdIWwBRYe9uMP a/RWssYcDYaEpTBS3sBLUR6AEvUS5j/sl525quN9TWSUENU0tBzubx+qfL9xeUvzyTNS F7Qf95fNy+hc7Ehhs7WEW1tyU5Yyx0PBFr3rB604G9hNXtv49fEPLvCEuczrK20EoRru DLNHEmXmFvz37CVVBTf+PFMqfiSwmOMT0/fsy5OJI22i1nQilIyWK7xKibgXpo3fzBxk 2Plg== X-Gm-Message-State: AMCzsaUc71hjOiEqoZ9n8iElXXxASY04QTfT6O/YG3n7MnezWkQhbd9Q xRZi4z/9GbXy7hJSqJpwtCxrEDfx X-Google-Smtp-Source: ABhQp+RFqIrebdnmBqK+EI3OSxOdkvPckVaTORxon+gWEFiRR2Rj1FsUPtJyMLSqorMu8TQIqf1+GQ== X-Received: by 10.13.239.7 with SMTP id y7mr3877924ywe.122.1509688470932; Thu, 02 Nov 2017 22:54:30 -0700 (PDT) Original-Received: from laythe (res380d-128-61-81-32.res.gatech.edu. [128.61.81.32]) by smtp.gmail.com with ESMTPSA id l141sm2311223ywe.102.2017.11.02.22.54.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 22:54:30 -0700 (PDT) In-Reply-To: <59FAEA9C.1050608@gmx.at> (martin rudalics's message of "Thu, 02 Nov 2017 10:51:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139387 Archived-At: Hi Martin, > Can you try replacing all =E2=80=98switch-to-buffer=E2=80=99 calls in the= erc directory > by =E2=80=98pop-to-buffer-same-window=E2=80=99 calls and test whether the= problem goes > away? I'm afraid I have no better proposal. I tried this, and it seems to restore keep-place functionality when switching to buffers with M-x erc-track-switch-buffer, but not with C-x b. I suspect the call to switch-to-buffer in C-x b isn't handled by erc, so changing the function won't help. Obviously, I don't think that's an acceptable solution. I can think of two solutions right now: 1. Add a new configuration option which allows keep-place mode to disable this setting dynamically, and on enabling keep-place, add erc buffers to the exempted list. I took a look at `switch-to-buffer' and I don't see any way this can be done without a new variable. I personally would like to use the new default for non-erc buffers, and I would suspect that others would like to turn it on selectively as well. 2. Make it impossible to miss that this variable must be turned off when keep-place is enabled. If this isn't done, people's config will silently break (which is pretty bad). I would think that keep-place should throw an error when this variable is t, to be safe (since it doesn't work at all when it is). What do you think? I would be happy if keep-place would work out of the box for new users of erc, but I'm not sure if that's possible... -Jay