From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 Date: Thu, 14 Dec 2017 20:16:20 -0500 Message-ID: <877etodc4b.fsf@users.sourceforge.net> References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1513300634 22971 195.159.176.226 (15 Dec 2017 01:17:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 01:17:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Ken Raeburn , Andreas Schwab , Philipp Stephani , 29165@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 15 02:17:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePecb-0005XV-7a for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Dec 2017 02:17:05 +0100 Original-Received: from localhost ([::1]:43679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePeci-0001eh-5r for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Dec 2017 20:17:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePecc-0001eV-BF for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2017 20:17:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePecY-0002ec-Mc for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2017 20:17:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePecY-0002eG-IR for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2017 20:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePecY-0000DX-97 for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2017 20:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Dec 2017 01:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29165 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 29165-submit@debbugs.gnu.org id=B29165.151330059131680 (code B ref 29165); Fri, 15 Dec 2017 01:17:02 +0000 Original-Received: (at 29165) by debbugs.gnu.org; 15 Dec 2017 01:16:31 +0000 Original-Received: from localhost ([127.0.0.1]:34327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePec1-0008DY-0O for submit@debbugs.gnu.org; Thu, 14 Dec 2017 20:16:29 -0500 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:35090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePec0-00089A-7H for 29165@debbugs.gnu.org; Thu, 14 Dec 2017 20:16:28 -0500 Original-Received: by mail-it0-f43.google.com with SMTP id f143so15446364itb.0 for <29165@debbugs.gnu.org>; Thu, 14 Dec 2017 17:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4XerAqh7dPT0MZn18hNVLLP+eLDNubMLeEJJ4TXqRMk=; b=cmFs3bOg23vIUPoZrAav96klavkWdSEbOBmE3es0BaAUHILyeH4bm6eooAmwN4H6qo Nxi/gEaRHqql9l/vIwWVWL+A2Fq7KDJrUtZ50fatVh76pFdMpaPjNX4c0GaNqUBk7xLB Q0Ydb8XKzvZ2lwDANoq+uAsQoGWJ0iVTpk18CFVlPYXjv0roxciCBGX23TwAGsJgzN4J Qf8eC/df0X2qnj3o/QXNND0wEXOd7iF0ROICh6k6xuHIKQeUAzoQPO7MwbBYUPa//kb2 BeQ7HNPLdYdYAeBuwguvZwHumeLh/F4X6NcONBTsoOm94GC2wpwtwUiLHa+tswswXBIo zPsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=4XerAqh7dPT0MZn18hNVLLP+eLDNubMLeEJJ4TXqRMk=; b=f72Ocp3yfNbH9ZamG0BNHi+9+dzG7p1J1R5CSHFG0wNcNR9pqL5u5zURMiV0sQelec W5z7z8gLEJd3UBvy3eXqMojRCcnjc+66Xp3GuSx5vE3Z7c17ql7zzGfcpBtfRQjjRs9t m3FJy19RE80GeAGgQn3/U1R5TeEg31AWBB1Ml12YmLY/YJDO/qLGCLDdCZXpzlYO7bha 9UfaJL1aUTZQpgP7kDMRo1BN8GR1SbU8st6Tjxenk/QYBMUrQLZmluEVL/0w2Xc/oW/u YjDrTItzZ96qKysJlWsfrz1R1i0p7TcjklWePjHn5NNmo+cgbW5YclGS+ZXzUH9mwzqP Kf9w== X-Gm-Message-State: AKGB3mIVdAUhC+esWGULU+XZz8qCoonL6FPj2FXOYBz86roRnbOU3v6T /N/ynhAmH1cIA30obLp7vLpCfg== X-Google-Smtp-Source: ACJfBos/jLA/ceBf+Ei8/fR44LhwB/Zc02jHWzHMQ+YHL3thL6ZKas0REygZ6mXxNDsaNBQZlwHsEg== X-Received: by 10.107.175.103 with SMTP id y100mr10504410ioe.48.1513300582595; Thu, 14 Dec 2017 17:16:22 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 140sm9773621itx.3.2017.12.14.17.16.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Dec 2017 17:16:21 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 13 Dec 2017 18:39:52 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141080 Archived-At: Stefan Monnier writes: >>> (And if we=E2=80=99re going to make that sort of thing an error, we sho= uld >>> probably check whether empty &key or &aux variable lists are similarly >>> rejected. I haven=E2=80=99t looked.) > > I recently installed a patch to fix/improve the behavior of &aux with no > keyword variable (I bumped into it while working on some Elisp package, > tho I can't remember which right now). > > I think it's usually worth the small extra effort to support &optional > not followed by any var (as well as &aux not followed by any var) since > it sometimes comes in handy. But not if it costs extra at run-time. I don't think there is any performance penalty (when running byte-compiled code anyway). Although I see that &optional at the end of the arglist has been a compile error for a long time (I tested back to 24.3). E.g., (defun foo (&optional)) fails to compile. (defun foo (&optional &rest)) happened to work, though I wouldn't exactly call that "support". >> Updated patch which handles &aux as well. I also tested a bootstrap >> (doing this I found the previous patch messed up some positive cases). > > To the extent that &aux is only handled by macro-expansion, accepting an > empty &aux never costs anything at run-time, so I think rejecting it is > a disservice to our users. I don't see the use case for empty &aux, but I don't mind reverting that change.