From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Jay Kamat <jaygkamat@gmail.com>
Cc: 29821@debbugs.gnu.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: bug#29821: Ensure quick substitution only occurs at start of line
Date: Thu, 04 Jan 2018 20:04:09 -0500 [thread overview]
Message-ID: <877esxru9i.fsf@users.sourceforge.net> (raw)
In-Reply-To: <877esxid5o.fsf@gmail.com> (Jay Kamat's message of "Thu, 04 Jan 2018 12:26:11 -0800")
Jay Kamat <jaygkamat@gmail.com> writes:
> Ah, nice catch! I've updated the patch to handle that case as well. I've
> tested it as well as I could and it seems good to me, but in order to
> fix that case, I had to mess with the regexes a bit, so It's possible I
> might have missed a few cases.
There doesn't need to be trailing whitespace between the last "^" and
subsequent text, bash:
~/tmp$ echo foo bar
foo bar
~/tmp$ ^foo^blah^x
echo blah barx
blah barx
eshell (with your patch):
~/src/emacs $ echo foo bar
("foo" "bar")
~/src/emacs $ ^foo^blah^x
^foo^blah^x: command not found
And as far as I can tell, trailing whitespace should not be dropped
(though it's hard to come up with cases where it matters):
~/tmp$ echo 'foo bar '
foo bar
~/tmp$ ^bar^zz
echo 'foo zz '
foo zz
So I think this should do it?
...
(string-match
"^\\^\\([^^]+\\)\\^\\([^^]+\\)\\(?:\\^\\(.*\\)\\)?$"
line))
;; Save trailing match as `eshell-history-reference' runs string-match.
(let ((matched-end (match-string 3 line)))
...
next prev parent reply other threads:[~2018-01-05 1:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 23:57 bug#29821: Ensure quick substitution only occurs at start of line Jay Kamat
2018-01-01 0:33 ` Noam Postavsky
2018-01-01 9:56 ` Andreas Schwab
2018-01-02 1:29 ` Noam Postavsky
2018-01-02 2:30 ` Jay Kamat
2018-01-02 3:58 ` Noam Postavsky
2018-01-02 17:48 ` Jay Kamat
2018-01-03 1:51 ` Noam Postavsky
2018-01-04 1:17 ` Jay Kamat
2018-01-04 3:10 ` Noam Postavsky
2018-01-04 20:26 ` Jay Kamat
2018-01-05 1:04 ` Noam Postavsky [this message]
2018-01-05 1:53 ` Jay Kamat
2018-01-05 14:31 ` Noam Postavsky
2018-01-01 23:44 ` Jay Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877esxru9i.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=29821@debbugs.gnu.org \
--cc=jaygkamat@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.