From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#30213: 26.0.91; shell buffer not displayed when not erased and async-shell-command-display-buffer is used Date: Tue, 23 Jan 2018 18:53:13 +0000 Message-ID: <877es8xv8m.fsf@tcd.ie> References: <87a7x5ejsu.fsf@gmail.com> <878tcpfmnz.fsf@tcd.ie> <87607s62zt.fsf@gmail.com> <874lnc62sj.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1516733543 28126 195.159.176.226 (23 Jan 2018 18:52:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 18:52:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30213@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 23 19:52:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee3g0-0006a4-TJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 19:52:09 +0100 Original-Received: from localhost ([::1]:46204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee3i1-0002Jq-8E for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 13:54:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee3hv-0002JM-0V for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 13:54:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee3hq-0002DZ-6L for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 13:54:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee3hp-0002DR-W8 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 13:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee3hp-0005eg-Mh for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 13:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30213-submit@debbugs.gnu.org id=B30213.151673360221685 (code B ref 30213); Tue, 23 Jan 2018 18:54:01 +0000 Original-Received: (at 30213) by debbugs.gnu.org; 23 Jan 2018 18:53:22 +0000 Original-Received: from localhost ([127.0.0.1]:39901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee3hC-0005dh-7t for submit@debbugs.gnu.org; Tue, 23 Jan 2018 13:53:22 -0500 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:46788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee3hA-0005dU-Pb for 30213@debbugs.gnu.org; Tue, 23 Jan 2018 13:53:21 -0500 Original-Received: by mail-wm0-f41.google.com with SMTP id 143so3801822wma.5 for <30213@debbugs.gnu.org>; Tue, 23 Jan 2018 10:53:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b1/BaofJmOogC9yvPk8tUpjrgF5hMM3xJws5dpjXM1w=; b=SQlqOpiKJa8FbRMZlbR7/OxzPq17xwQapfhruDdPCnrykNhf31KUBHjUnKdZw2sbpM VRdCoKLrYqDa4EiFXmqnkT/TfVw54ROdq2zdHdRijR1z0N2mZSjAh5V5oG4TN/7zh8d7 t8A8yL+2Sy9yebkLalF7N+v4ToNt9YONHnuuxSP39z+Qm9l6u/coAS+5x+4yzWMvro7I mH7qc2hg3fJ/PDBVD5h3GMTvV9Tl1LouMfRircObo/oTyvfOwlINZIEU3WmPlLhX+1+I LyLXX+qgx04hxVqsKwFfDgGOwcaeLDYGEuhD5pceUq9zVneAdcUy0mGf0vls3W+//YL+ HPlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=b1/BaofJmOogC9yvPk8tUpjrgF5hMM3xJws5dpjXM1w=; b=E7GpLIzHGBNMpchvJh6m+vyP+Dh7/54vZfPLzPLPB92EV8Q/gpyzkQ37+Ng6kJTTgu SnX834aIsBELbPHD/rhDyv0eOtmgOl2uTXVOjnrpdfmk9kJf3MHpjRJbYZnY3YkvCc7r P2iFbQPRMf2WQHzCKMyxiWG67hCQ2s+pBDwt58tw7IeWFWfzHCRiPi7lpGwY94oGko53 gPGTK2/vY8Pn7A7IhQqkZ1GWy1fzi+vOoUYQShuZiP/8AoXDjwoauVRyoWwKUljQn04Q k7GI9f6UHyqnE9dGL80yUeB8kl8nuX+oJl279wHAFu1diSLSZaTrOWJRQ/uodtSRHKwE RyaQ== X-Gm-Message-State: AKwxytdVa9eBfGlU6CHs3cQpsb8wauPXPWcnhyPoluHcb/ErM+XCrgrs /Ij8u3PHQlXCGulgY12vVbT2rA== X-Google-Smtp-Source: AH8x227OkfswHLkEQ6HUrstNSlI4LGHBdSOaQzdyTUYKdkfOYUiYYJd571Qhip2BB5xEY3lccCZing== X-Received: by 10.80.208.197 with SMTP id g5mr20666501edf.216.1516733594867; Tue, 23 Jan 2018 10:53:14 -0800 (PST) Original-Received: from localhost ([213.233.148.30]) by smtp.gmail.com with ESMTPSA id x25sm13741543eda.8.2018.01.23.10.53.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2018 10:53:14 -0800 (PST) In-Reply-To: <874lnc62sj.fsf@gmail.com> (Alex Branham's message of "Tue, 23 Jan 2018 08:57:32 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142443 Archived-At: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-deferred-display-of-async-shell-command-buffer.patch >From c236ef15477a7d76ee0420794f149bbcafdc8798 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Tue, 23 Jan 2018 18:18:04 +0000 Subject: [PATCH] Fix deferred display of async shell-command buffer * lisp/simple.el (shell-command): Display async command buffer on process output for every invocation, not just the first. (bug#30213) --- lisp/simple.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 3ac6b86381..20e22bf98f 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -3551,9 +3551,7 @@ shell-command (add-function :before (process-filter proc) (lambda (process _string) (let ((buf (process-buffer process))) - (when (and (zerop (buffer-size buf)) - (string= (buffer-name buf) - bname)) + (when (string= (buffer-name buf) bname) (display-buffer buf)))))))) ;; Otherwise, command is executed synchronously. (shell-command-on-region (point) (point) command -- 2.15.1 --=-=-= Content-Type: text/plain Alex Branham writes: > I'm sorry, haven't had my morning coffee yet. I can reproduce this, but there > was an error in my initial email. From emacs -Q > > (setq shell-command-dont-erase-buffer 'beg-last-out > async-shell-command-display-buffer nil) > > then do an async shell command, delete the window that shows the output, then > call another async shell command. The window is never re-shown. Thanks, I'm able to reproduce this on both emacs-26 and master branches and believe the attached patch fixes the issue. -- Basil --=-=-=--