From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Alex Branham <alex.branham@gmail.com>
Cc: 30213@debbugs.gnu.org
Subject: bug#30213: 26.0.91; shell buffer not displayed when not erased and async-shell-command-display-buffer is used
Date: Tue, 23 Jan 2018 18:53:13 +0000 [thread overview]
Message-ID: <877es8xv8m.fsf@tcd.ie> (raw)
In-Reply-To: <874lnc62sj.fsf@gmail.com> (Alex Branham's message of "Tue, 23 Jan 2018 08:57:32 -0600")
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Fix-deferred-display-of-async-shell-command-buffer.patch --]
[-- Type: text/x-diff, Size: 1291 bytes --]
From c236ef15477a7d76ee0420794f149bbcafdc8798 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Tue, 23 Jan 2018 18:18:04 +0000
Subject: [PATCH] Fix deferred display of async shell-command buffer
* lisp/simple.el (shell-command): Display async command buffer on
process output for every invocation, not just the first. (bug#30213)
---
lisp/simple.el | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lisp/simple.el b/lisp/simple.el
index 3ac6b86381..20e22bf98f 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3551,9 +3551,7 @@ shell-command
(add-function :before (process-filter proc)
(lambda (process _string)
(let ((buf (process-buffer process)))
- (when (and (zerop (buffer-size buf))
- (string= (buffer-name buf)
- bname))
+ (when (string= (buffer-name buf) bname)
(display-buffer buf))))))))
;; Otherwise, command is executed synchronously.
(shell-command-on-region (point) (point) command
--
2.15.1
[-- Attachment #2: Type: text/plain, Size: 562 bytes --]
Alex Branham <alex.branham@gmail.com> writes:
> I'm sorry, haven't had my morning coffee yet. I can reproduce this, but there
> was an error in my initial email. From emacs -Q
>
> (setq shell-command-dont-erase-buffer 'beg-last-out
> async-shell-command-display-buffer nil)
>
> then do an async shell command, delete the window that shows the output, then
> call another async shell command. The window is never re-shown.
Thanks, I'm able to reproduce this on both emacs-26 and master branches
and believe the attached patch fixes the issue.
--
Basil
next prev parent reply other threads:[~2018-01-23 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 20:10 bug#30213: 26.0.91; shell buffer not displayed when not erased and async-shell-command-display-buffer is used Alex Branham
2018-01-23 0:23 ` Basil L. Contovounesios
2018-01-23 14:53 ` Alex Branham
2018-01-23 14:57 ` Alex Branham
2018-01-23 18:53 ` Basil L. Contovounesios [this message]
2018-01-23 19:07 ` Alex Branham
2018-01-23 19:30 ` Eli Zaretskii
2018-01-23 22:44 ` Basil L. Contovounesios
2018-02-03 21:31 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877es8xv8m.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=30213@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.