From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 19045@debbugs.gnu.org
Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow
Date: Tue, 06 Feb 2018 23:04:28 +0200 [thread overview]
Message-ID: <877erpygmb.fsf@mail.linkov.net> (raw)
In-Reply-To: <83vafa7plz.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Feb 2018 05:40:08 +0200")
> Would binding resize-mini-windows to nil instead fix that? If it
> would, then I think it's a better way, because it doesn't affect what
> is being recorded in *Messages*.
I created a patch below that let-binds resize-mini-windows to nil,
but it has no effect and always resizes the echo area.
Should I create a separate bug report for this?
Also there is still a problem of hiding the trailing part with
“in background... done” when it is not displayed at the end of
the message, and I have no idea how to reformulate this phrase.
diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el
index b0d2221..a3d8e3d 100644
--- a/lisp/vc/vc-dispatcher.el
+++ b/lisp/vc/vc-dispatcher.el
@@ -290,16 +290,12 @@ vc-do-command
(let* ((files
(mapcar (lambda (f) (file-relative-name (expand-file-name f)))
(if (listp file-or-list) file-or-list (list file-or-list))))
+ (resize-mini-windows nil)
(full-command
- ;; What we're doing here is preparing a version of the command
- ;; for display in a debug-progress message. If it's fewer than
- ;; 20 characters display the entire command (without trailing
- ;; newline). Otherwise display the first 20 followed by an ellipsis.
(concat (if (string= (substring command -1) "\n")
(substring command 0 -1)
command)
- " "
- (vc-delistify (mapcar (lambda (s) (if (> (length s) 20) (concat (substring s 0 2) "...") s)) flags))
+ " " (vc-delistify flags)
" " (vc-delistify files))))
(save-current-buffer
(unless (or (eq buffer t)
@@ -332,7 +328,8 @@ vc-do-command
(setq status proc)
(when vc-command-messages
(vc-run-delayed
- (message "Running %s in background... done" full-command))))
+ (let ((resize-mini-windows nil))
+ (message "Running %s in background... done" full-command)))))
;; Run synchronously
(when vc-command-messages
(message "Running %s in foreground..." full-command))
next prev parent reply other threads:[~2018-02-06 21:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 17:05 bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Óscar Fuentes
2014-11-13 19:07 ` Dmitry Gutov
2014-11-13 21:11 ` Óscar Fuentes
2018-02-03 21:59 ` Juri Linkov
2018-02-04 21:58 ` Juri Linkov
2018-02-04 23:31 ` Dmitry Gutov
2018-02-05 3:39 ` Eli Zaretskii
2018-02-05 8:25 ` Dmitry Gutov
2018-02-05 16:18 ` Eli Zaretskii
2018-02-05 20:11 ` Dmitry Gutov
2018-02-05 21:31 ` Juri Linkov
2018-02-06 20:46 ` Dmitry Gutov
2018-02-06 21:51 ` Juri Linkov
2018-02-08 22:08 ` Dmitry Gutov
2018-02-10 21:14 ` Juri Linkov
2018-02-12 0:18 ` Dmitry Gutov
2018-02-15 22:07 ` Juri Linkov
2018-02-16 8:00 ` Eli Zaretskii
2018-02-16 10:20 ` Dmitry Gutov
2018-02-16 10:52 ` Eli Zaretskii
2018-02-18 0:13 ` Richard Stallman
2018-02-20 20:39 ` Juri Linkov
2018-02-21 3:36 ` Eli Zaretskii
2018-02-05 3:33 ` Eli Zaretskii
2018-02-05 21:17 ` Juri Linkov
2018-02-06 3:40 ` Eli Zaretskii
2018-02-06 21:04 ` Juri Linkov [this message]
2018-02-08 15:54 ` Eli Zaretskii
2018-02-08 21:09 ` Juri Linkov
2018-02-09 7:08 ` Eli Zaretskii
2018-02-10 11:07 ` Eli Zaretskii
2018-02-10 21:08 ` Juri Linkov
2018-02-11 16:24 ` Eli Zaretskii
2018-02-11 17:03 ` Andreas Schwab
2018-02-11 17:25 ` Eli Zaretskii
2018-02-11 18:22 ` Andreas Schwab
2018-02-11 18:49 ` Eli Zaretskii
2018-02-11 21:22 ` Juri Linkov
2018-02-12 18:09 ` Eli Zaretskii
2018-02-12 21:50 ` Juri Linkov
2018-02-13 5:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877erpygmb.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=19045@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.