bug#30883: 27.0.50; completions-annotations face should not be based on italic by default

bug#30883: 27.0.50; completions-annotations face should not be based on italic by default

[Robert Pluim]

When using insert-char interactively to insert т (CYRILLIC SMALL
LETTER TE), the completions buffer uses the completions-annotations
face to display the character after the full unicode name. т is one of
those characters for which the italic glyph is very different from the
non-italic one (it actually looks like an 'm'), which is highly
misleading for the user.

The easy solution would be to just base the completions-annotations
face on the default face, but Iʼm sure thereʼs a historical reason for
its existence.

In GNU Emacs 27.0.50 (build 27, x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2018-03-19 built on rpluim-ubuntu
Repository revision: 2dd2251ce5c676f64bfed3cd56d4746213e75583
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description: KDE neon LTS User Edition 5.12

bug#30883: 27.0.50; completions-annotations face should not be based on italic by default

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Date: Tue, 20 Mar 2018 17:16:37 +0100
> 
> When using insert-char interactively to insert т (CYRILLIC SMALL
> LETTER TE), the completions buffer uses the completions-annotations
> face to display the character after the full unicode name. т is one of
> those characters for which the italic glyph is very different from the
> non-italic one (it actually looks like an 'm'), which is highly
> misleading for the user.

I guess it depends on the default font, because on my system the
italic glyph looks very reasonably similar to the roman variant.

> The easy solution would be to just base the completions-annotations
> face on the default face, but Iʼm sure thereʼs a historical reason for
> its existence.

FWIW, I happen to like the typeface we use there, so I think we should
go to a more boring display only if we have a very good reason.

Thanks.

bug#30883: 27.0.50; completions-annotations face should not be based on italic by default

[Robert Pluim]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Tue, 20 Mar 2018 17:16:37 +0100
>> 
>> When using insert-char interactively to insert т (CYRILLIC SMALL
>> LETTER TE), the completions buffer uses the completions-annotations
>> face to display the character after the full unicode name. т is one of
>> those characters for which the italic glyph is very different from the
>> non-italic one (it actually looks like an 'm'), which is highly
>> misleading for the user.
>
> I guess it depends on the default font, because on my system the
> italic glyph looks very reasonably similar to the roman variant.

It does. The following monospace fonts on my system display it as a
slanted 'm': Inconsolata, Libertine, Noto Sans UI, Ubuntu Mono. The
others display it as a slanted т, which is arguably incorrect, but
they outnumber those four by approximately 2:1

>> The easy solution would be to just base the completions-annotations
>> face on the default face, but Iʼm sure thereʼs a historical reason for
>> its existence.
>
> FWIW, I happen to like the typeface we use there, so I think we should
> go to a more boring display only if we have a very good reason.

I donʼt think we have a good reason. Iʼll customise
completions-annotations.


Robert

bug#30883: 27.0.50; completions-annotations face should not be based on italic by default

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> When using insert-char interactively to insert т (CYRILLIC SMALL
> LETTER TE), the completions buffer uses the completions-annotations
> face to display the character after the full unicode name.

This has been changed in Emacs 28 -- the character is displayed at the
start of the line in *completions*, and it's not italic.  (But I see the
problem in Emacs 27.1.)

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no