From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29156: 25.3; eshell/kill does not understand -, [PATCH] Make eshell/kill handle - and - Date: Thu, 22 Mar 2018 21:05:33 -0400 Message-ID: <877eq3sisi.fsf@gmail.com> References: <87vaiprmg5.fsf@gmail.com> <87o9jnv9et.fsf@gmail.com> <87lgerv8tq.fsf@gmail.com> <83lgeroz7r.fsf@gnu.org> <87zi3661j2.fsf@pagefault.se> <83a7v6pkdf.fsf@gnu.org> <87muz65rh9.fsf@pagefault.se> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521767053 30038 195.159.176.226 (23 Mar 2018 01:04:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2018 01:04:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29156@debbugs.gnu.org, ambrevar@gmail.com To: Eric Skoglund Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 23 02:04:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezB7p-0007k2-0h for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 02:04:09 +0100 Original-Received: from localhost ([::1]:35518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezB9q-0001sG-GT for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 21:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezB9j-0001qN-DC for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 21:06:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezB9e-00073p-5a for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 21:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40392) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezB9e-00073k-17 for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 21:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezB9d-0006v1-IG for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 21:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Mar 2018 01:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 29156-submit@debbugs.gnu.org id=B29156.152176714226568 (code B ref 29156); Fri, 23 Mar 2018 01:06:01 +0000 Original-Received: (at 29156) by debbugs.gnu.org; 23 Mar 2018 01:05:42 +0000 Original-Received: from localhost ([127.0.0.1]:48289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezB9J-0006uS-UC for submit@debbugs.gnu.org; Thu, 22 Mar 2018 21:05:42 -0400 Original-Received: from mail-it0-f49.google.com ([209.85.214.49]:52748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezB9J-0006uC-6y for 29156@debbugs.gnu.org; Thu, 22 Mar 2018 21:05:41 -0400 Original-Received: by mail-it0-f49.google.com with SMTP id k135-v6so629286ite.2 for <29156@debbugs.gnu.org>; Thu, 22 Mar 2018 18:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5uLbarcghPls9qQ3xLmtzqbIyTOWwIl9xY4rgqVqCC4=; b=gA+1GU8xCQBXzW0VaZWIIjnj/wXkZDU9OeQhcNY8sze00OHoxrTlyLAz3Lbm4zbesd sPe9pNnd2EPkMzIDY/mP1PqqtJmomjL6tldtK/lkU0fUBm4H1QBGrLDEHs/Wo4yDgKba jyXjSBtijrSr8u/2Lawjq5t5BavHBHQCsggbfGljW+WIXgw9vcZEf6GqPpz+baTtiJic j2Of/TAS4k+CsLvMiIHvLgwffqCpJ1GxQ4EeWDqripktiVRvjtlflh4JS8fV5FfrFwvJ tVQmG9ICodm2ukRktlu4fw5F/U6vxKd+FKsPIAw1uphtiPewAXGSbFgjiDTHYNAnV4eA QGOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5uLbarcghPls9qQ3xLmtzqbIyTOWwIl9xY4rgqVqCC4=; b=TS/Z9jUnfZo/NHHUEH6nyDAKu+o+72lWYogvdKWFZLQ18+vFkMU1EmE5DkTorcmSC5 wc+68KONznYwxlYpCkLxn4RU2PB0hi1xeBMsCBq5WF+V3/EfspkPjKLrnI9oPynxBZ4v jb4kw9/T6NsAxrOtbaATgtw1X4+f8oL6RcGTTuv+b4IKeWHSp1AXTFJ89rf4GIPBnDF7 EVOn2p+m4SAxJWuZ5stDBNmL1T0XcGGAJWoXHVT7N/GDhOWyvDK0a4dF7FHgjHIqBtsJ YKBxR+Jt04FPGDpRpuy1Anbt3QxUQ2vu/0PAItgpMiegHfTCdxIlPsgQ9gM6fsosYsQ0 Yl+w== X-Gm-Message-State: AElRT7EKil8ek8fGU7r3R52ye7mLKnvQF4N+/hILRSsbNoYXLWdXilqD RCOI8SFGYPdu4pgZo17T+ag= X-Google-Smtp-Source: AG47ELvMA/vKdiqOgkhlUHY1jUcA9iKzn1alx0gFGMC8MCOaYSkBIBU/6etBQRk3gvkft2wKDLS4mA== X-Received: by 2002:a24:1a10:: with SMTP id 16-v6mr3559012iti.9.1521767135802; Thu, 22 Mar 2018 18:05:35 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v2sm5295241iob.21.2018.03.22.18.05.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Mar 2018 18:05:34 -0700 (PDT) In-Reply-To: <87muz65rh9.fsf@pagefault.se> (Eric Skoglund's message of "Sat, 17 Mar 2018 22:20:34 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144544 Archived-At: Thanks, do you have copyright assignment for Emacs? (the change is small enough to install regardless, I'm asking just to know if it should be marked as a tiny change). A couple more minor nitpicks: > * doc/misc/eshell.texi (kill): Update docs to reflect new > function behaviour > * etc/NEWS: Mention new eshell/kill behaviour Missing periods here. > + (setq signum (intern (substring arg 1 (length arg)))))) That could be just (substring arg 1) P.S. don't worry about the forwarding thing, it happens often enough that I've written an Emacs command to mostly automate it.