From: Noam Postavsky <npostavs@gmail.com>
To: Eric Skoglund <eric@pagefault.se>
Cc: 29156@debbugs.gnu.org, ambrevar@gmail.com
Subject: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>
Date: Thu, 22 Mar 2018 21:05:33 -0400 [thread overview]
Message-ID: <877eq3sisi.fsf@gmail.com> (raw)
In-Reply-To: <87muz65rh9.fsf@pagefault.se> (Eric Skoglund's message of "Sat, 17 Mar 2018 22:20:34 +0100")
Thanks, do you have copyright assignment for Emacs? (the change is small
enough to install regardless, I'm asking just to know if it should be
marked as a tiny change).
A couple more minor nitpicks:
> * doc/misc/eshell.texi (kill): Update docs to reflect new
> function behaviour
> * etc/NEWS: Mention new eshell/kill behaviour
Missing periods here.
> + (setq signum (intern (substring arg 1 (length arg))))))
That could be just (substring arg 1)
P.S. don't worry about the forwarding thing, it happens often enough
that I've written an Emacs command to mostly automate it.
next prev parent reply other threads:[~2018-03-23 1:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 11:31 bug#29156: 25.3; eshell/kill does not understand -<signal> Pierre Neidhardt
2017-11-05 12:38 ` Noam Postavsky
2018-03-17 0:21 ` bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME> Noam Postavsky
2018-03-17 0:34 ` Noam Postavsky
2018-03-17 8:58 ` Eli Zaretskii
2018-03-17 17:43 ` Eric Skoglund
2018-03-17 19:33 ` Eli Zaretskii
[not found] ` <87muz65rh9.fsf@pagefault.se>
2018-03-23 1:05 ` Noam Postavsky [this message]
2018-03-23 6:03 ` Eric Skoglund
2018-03-25 15:34 ` Noam Postavsky
2018-03-17 14:43 ` Noam Postavsky
2018-03-17 14:54 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eq3sisi.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=29156@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
--cc=eric@pagefault.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.