From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#31232: 27.0.50; Obsolete argument RESULT in the macro `dotimes' Date: Sat, 21 Apr 2018 23:53:44 +0300 Organization: LINKOV.NET Message-ID: <877ep0jn6v.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524344287 17190 195.159.176.226 (21 Apr 2018 20:58:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 21 Apr 2018 20:58:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) To: 31232@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 21 22:58:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9za7-0004Os-JE for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Apr 2018 22:58:03 +0200 Original-Received: from localhost ([::1]:46131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9zcE-0006gN-GD for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Apr 2018 17:00:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9za7-0005RQ-SK for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 16:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9za6-0007WW-TP for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 16:58:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55540) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f9za6-0007WB-Qk for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 16:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f9za6-0001gZ-Jb for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 16:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Apr 2018 20:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15243442566446 (code B ref -1); Sat, 21 Apr 2018 20:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Apr 2018 20:57:36 +0000 Original-Received: from localhost ([127.0.0.1]:35204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9zZg-0001fu-7v for submit@debbugs.gnu.org; Sat, 21 Apr 2018 16:57:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9zZe-0001ff-B4 for submit@debbugs.gnu.org; Sat, 21 Apr 2018 16:57:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9zZY-0006er-Fs for submit@debbugs.gnu.org; Sat, 21 Apr 2018 16:57:29 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9zZY-0006ea-9r for submit@debbugs.gnu.org; Sat, 21 Apr 2018 16:57:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9zZX-00055T-9D for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 16:57:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9zZW-0006c7-Jp for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 16:57:27 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:42695 helo=homiemail-a100.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9zZW-0006b1-EJ for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2018 16:57:26 -0400 Original-Received: from homiemail-a100.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a100.g.dreamhost.com (Postfix) with ESMTP id 7150031A070 for ; Sat, 21 Apr 2018 13:57:25 -0700 (PDT) Original-Received: from localhost.linkov.net (m91-129-110-22.cust.tele2.ee [91.129.110.22]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a100.g.dreamhost.com (Postfix) with ESMTPSA id C6A4A31A061 for ; Sat, 21 Apr 2018 13:57:24 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145655 Archived-At: If the arg RESULT of dotimes is not yet deprecated, then to legitimize its usage it needs to be fixed. At least, this patch tries to do this (maybe not in the best way): diff --git a/lisp/subr.el b/lisp/subr.el index 9cf7d59..aa2dc49 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -246,8 +246,8 @@ dotimes ,@body) (setq ,counter (1+ ,counter))) ,@(if (cddr spec) - ;; FIXME: This let often leads to "unused var" warnings. - `((let ((,(car spec) ,counter)) ,@(cddr spec)))))) + ;; No-op ,(car spec) is added to avoid "unused var" warnings. + `((let ((,(car spec) ,counter)) ,(car spec) ,@(cddr spec)))))) `(let ((,temp ,end) (,(car spec) ,start)) (while (< ,(car spec) ,temp)