From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Benjamin Motz <benni.motz@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/2] org-colview.el: Add property :exclude-tags to column view
Date: Sat, 07 Jul 2018 09:31:15 +0200 [thread overview]
Message-ID: <877em733jw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zhz46mbx.fsf@gmail.com> (Benjamin Motz's message of "Sat, 07 Jul 2018 00:17:22 +0200")
Hello,
Benjamin Motz <benni.motz@gmail.com> writes:
> This addition allows to specify a list of tags to exclude from column
> view tables.
>
> From 4ac32c4b24f33b841ad73c4b10158ec7a18087a9 Mon Sep 17 00:00:00 2001
> From: Benjamin Motz <benni.motz@gmail.com>
> Date: Wed, 4 Jul 2018 14:27:24 +0200
> Subject: [PATCH 2/2] org-colview.el: Add property :exclude-tags to column view
> table
>
> This addition allows to specify a list of tags to exclude from column
> view tables.
>
> TINYCHANGE
It looks good. This need to be documented in the manual, though. Would you
mind adding this to your patch.
Also, a test would be nice in "test-org-colview.el", more accurately in
`test-org-colview/dblock'. Could you add one?
> -(defun org-columns--capture-view (maxlevel match skip-empty format local)
> +(defun org-columns--capture-view (maxlevel match skip-empty exclude-tags format local)
> "Get the column view of the current buffer.
You need to describe the new argument in the docstring.
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-07-07 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 22:17 [PATCH 2/2] org-colview.el: Add property :exclude-tags to column view Benjamin Motz
2018-07-07 7:31 ` Nicolas Goaziou [this message]
2018-07-07 13:21 ` Benjamin Motz
2018-07-09 12:33 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877em733jw.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=benni.motz@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.